1629282 - Update Swedish holiday calendar (2020-2029)

Status: RESOLVED MOVED

(Calendar :: Website, defect)

Description

[Erik Lundin]

Attachment: Sweden Holidays.ics

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

The current holiday calendar at https://www.thunderbird.net/en-US/calendar/holidays/ needs updating. A new calendar file covering 2020-2029 is attached. Generated using https://github.com/f03el/swedish-holiday-calendar-generator.

Comment 1

[Firefox Bug Husbandry Bot]

Resetting severity to default of --.

Comment 2

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 3

[Erik Lundin]

Unfortunately, I recently found a problem with the RRULEs for Allhelgonaafton (All Saints' Eve) and Alla helgons dag (All Saints' Day). The former is located on the Friday between 30 October and 5 November, and the latter on the Saturday between the 31 October and 6 November. The rules worked fine for 2019, but for 2020, the current rules match twice. Does anyone know how to write the rules to elegantly only match once a year?

Current rules in my suggested calendar:

• Allhelgonaafton: RRULE:FREQ=YEARLY;BYDAY=FR;BYMONTHDAY=30,31,1,2,3,4,5;BYMONTH=10,11
• Alla helgons dag: RRULE:FREQ=YEARLY;BYDAY=SA;BYMONTHDAY=31,1,2,3,4,5,6;BYMONTH=10,11

If possible, I'd like to express them as RRULEs, and not have to create unique events for every year.

Comment 4

[Erik Lundin]

Attachment: Sweden Holidays.ics

New version of the calendar, with Allhelgonaafton and Alla helgons dag split into two recurring events each (the first event is for October and the second for November).

Comment 5

[Erik Lundin]

How many years is adequate for the calendar to cover? If there's a lot of work to get this fix accepted, we might as well create some headroom to not have to do it too often. Yes, the public holidays will certainly change at some point, but until then, a calendar with long coverage may be good (but I guess it shouldn't be too big, to cause unnecessary traffic). Using the script linked above, it's easy to produce calendars for an arbitrary number of years.

• 10 years: 17 kB
• 20 years: 30 kB
• 30 years: 43 kB
• 40 years: 56 kB
• 50 years: 69 kB

Comment 6

[Martin Schröder [:mschroeder]]

Erik, a calendar being valid for 10 years should be enough. There is a new process to contribute a calendar in place, see the instructions below. If you have any questions, just ask here.

Contributing a Holiday Calendar

If you would like to send us your calendar files, please follow these steps:

1. Create a new local calendar, e.g. "$Country$ Holidays".
2. Create the different holidays of your country in this local calendar.
3. Right-click on this calendar and choose "Export Calendar". Please use the iCalendar (ics) format.
4. Create a Pull Request or file an Issue on the website repository (https://github.com/thundernest/thunderbird-website) and attach your holiday file.

Comment 7

[Erik Lundin]

Thanks, I created a new PR. I guess this bug can be closed now?

Comment 8

[Martin Schröder [:mschroeder]]

Thank you!

Comment 9

[David Hedlund]

Add "De facto holiday" to calendar categories - https://bugzilla.mozilla.org/show_bug.cgi?id=1544287 -- Depends on:

• allow view filters on calendar - https://bugzilla.mozilla.org/show_bug.cgi?id=1549957
• automatic copying of calendar event from one calendar to another based on criteria - https://bugzilla.mozilla.org/show_bug.cgi?id=1549958