1544287 - Add "De facto holiday" to calendar categories

Status: UNCONFIRMED

(Calendar :: Preferences, enhancement)

Description

[David Hedlund]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

Some countries have de facto holidays (https://en.wikipedia.org/wiki/Special:Search?search=De%20facto%20holiday&go=Go&ns0=1) and I think de facto holidays should be distinguished from public holidays (https://bugzilla.mozilla.org/show_bug.cgi?id=1236747).

I visited Preferences -> Calendar -> Categories but could not find "De facto holiday" and it's not listed under "Category" for new events.

Actual results:

Could not find "De facto holiday".

Expected results:

Please add "De facto holiday" as a new calendar category.

Comment 1

[WaltS48 [:walts48]]

Attachment: DefactoHoliday.png

You should be able to do that yourself by clicking the New button.

Preferences > Calendar > Categories.

I used my test profile to make sure it worked. It even has a color!

Comment 2

[David Hedlund]

(In reply to WaltS48 [:walts48] from comment #1)

Created attachment 9058157 [details]
DefactoHoliday.png

You should be able to do that yourself by clicking the New button.

Preferences > Calendar > Categories.

I used my test profile to make sure it worked. It even has a color!

Thanks but I want "De facto holiday" added to the Lightning category list.

Comment 3

[WaltS48 [:walts48]]

That is what I did, not spelled exactly that way.

Not understanding why you want the developers to do the work for you when you can add it yourself, but I'll reopen the bug.

Comment 4

[David Hedlund]

(In reply to WaltS48 [:walts48] from comment #3)

That is what I did, not spelled exactly that way.

Not understanding why you want the developers to do the work for you when you can add it yourself, but I'll reopen the bug.

It's needed for people who wish to develop calendars as I've already explained.

Comment 5

[WaltS48 [:walts48]]

Categories aren't Calendars.

There is only the default Home calendar in the Calendar List.

Here is how you create new calendars.

https://support.mozilla.org/en-US/kb/creating-new-calendars

Comment 6

[David Hedlund]

(In reply to WaltS48 [:walts48] from comment #5)

Categories aren't Calendars.

Calendars are made of events, we need the new event category to make calendars. I don't have time to discuss this further.

Comment 7

[WaltS48 [:walts48]]

(In reply to David Hedlund from comment #6)

(In reply to WaltS48 [:walts48] from comment #5)

Categories aren't Calendars.

Calendars are made of events, we need the new event category to make calendars. I don't have time to discuss this further.

So why don't you create the category using the "New" button?

Yes Events are added to calendars.

Categories assign a category to that event.

For example, I created a Bills calendar on my computer where I create events for bill payments and add them to that calendar.

I don't use categories at all.

If you need one for a certain calendar then create it using the "New" button.

Feel free to reply when you have time.

Comment 8

[David Hedlund]

Feel free to reply when you have time.

I said "I don't have time to discuss this further."

Comment 9

[WaltS48 [:walts48]]

Well, then why did you file the bug report?

I'm trying to understand why you can't add the category yourself and don't understand what it is you want the developers to do, so I'm trying to assist in that determination.

Comment 10

[David Hedlund]

(In reply to WaltS48 [:walts48] from comment #9)

Well, then why did you file the bug report?

I'm trying to understand why you can't add the category yourself and don't understand what it is you want the developers to do, so I'm trying to assist in that determination.

You just ruined my day.

Comment 11

[WaltS48 [:walts48]]

Sorry that you don't want to answer a simple question and for spending good amount of my day trying to understand what it is you want and trying to assist you.

I'll remove myself from the CC: list and hope that brightens your day.

Comment 12

[David Hedlund]

(In reply to WaltS48 [:walts48] from comment #11)

Sorry that you don't want to answer a simple question and for spending good amount of my day trying to understand what it is you want and trying to assist you.

I'll remove myself from the CC: list and hope that brightens your day.

Thank you, and I also want to thank you for some of your earlier work on the issues.

Comment 13

[Stefan Sitter [:ssitter]]

Nominating WONTFIX. Every Lightning localization ships its own list of default categories. Users already can define there own categories. I don't see any use in adding just another random category.

Comment 14

[David Hedlund]

(In reply to Stefan Sitter [:ssitter] from comment #13)

Every Lightning localization ships its own list of default categories.

What? Please explain more about this.

Comment 15

[Stefan Sitter [:ssitter]]

The list of categories that is initialized when you install Lightning the very first time dependents on the language of Thunderbird: https://dxr.mozilla.org/l10n-central/search?q=categories2&redirect=false

Comment 16

[David Hedlund]

(In reply to Stefan Sitter [:ssitter] from comment #15)

The list of categories that is initialized when you install Lightning the very first time dependents on the language of Thunderbird: https://dxr.mozilla.org/l10n-central/search?q=categories2&redirect=false
(In reply to Stefan Sitter [:ssitter] from comment #13)

I don't see any use in adding just another random category.

It's not a random category, some working places require employees to work at de facto holidays. See the blocked bug for more information.

Comment 17

[David Hedlund]

(In reply to Stefan Sitter [:ssitter] from comment #15)

The list of categories that is initialized when you install Lightning the very first time dependents on the language of Thunderbird: https://dxr.mozilla.org/l10n-central/search?q=categories2&redirect=false

Thanks. "De facto holidays" can be translated and added to several countries. Example, "De facto helgdag" for Sweden.

Comment 18

[Ryan Lee Sipes]

Hi, I'm not sure this bug is all that helpful at this point. I'd ask folks to pause this conversation while I get some feedback on what the right way forward is here.

I'm looking at the block bug on this as well: https://bugzilla.mozilla.org/show_bug.cgi?id=1236747

Comment 19

[Ryan Lee Sipes]

Bugs 1549957 and 1549958 have been generated to address this.

We believe chasing these two features should allow for functionality that can be used to accomplish what you would like.

Comment 20

[David Hedlund]

(In reply to Ryan Sipes from comment #19)

Bugs 1549957 and 1549958 have been generated to address this.

Do you want to add them to "See Also" here?

Comment 21

[Ryan Lee Sipes]

(In reply to David Hedlund from comment #20)

(In reply to Ryan Sipes from comment #19)

Bugs 1549957 and 1549958 have been generated to address this.

Do you want to add them to "See Also" here?

Good idea, done!

Comment 22

[David Hedlund]

A useful calendar to test this feature in the future is the Swedish calendar published at https://www.thunderbird.net/en-US/calendar/holidays/ is based on https://github.com/f03el/swedish-holiday-calendar-generator/blob/master/generator.py (see Update Swedish holiday calendar (2020-2029) https://bugzilla.mozilla.org/show_bug.cgi?id=1629282):

    if work == Work.DEPENDS:
        self.add('categories', ('Ledighet enligt avtal',))
        self.add('description',
                 ('Denna dag har inte lagstadgad ställning som arbetsfri'
                  ' dag. Många arbetsplatser har ändå förkortad arbetstid'
                  ' enligt kollektivavtal eller lokala avtal.'))
    elif work == Work.DEFACTO:
        self.add('description',
                 ('Denna dag räknas som söndag enligt 3 a § i Semesterlagen'
                  ' och är därmed arbetsfri.'))