1632443 - pinch zooming with direct manipulation and webrender leads to no visual updates at all

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Comment 1

[Timothy Nikkel (:tnikkel)]

Jamie pointed me to
https://hg.mozilla.org/mozilla-central/rev/dd0e1c0d6acc4b7cb8b8b251aa3da7984f8b496f
which seems to cause the problem

Comment 2

[Timothy Nikkel (:tnikkel)]

This seems to be randomly intermittent. Sometimes I can reproduce consistently, but now I can't reproduce at all. I suspect this is still a problem though.

Comment 3

[Kris Taeleman (:ktaeleman)]

@jnicol: Could you do a bit of an explanation what you think is going on so we can ask Glenn on how to move forward with this?

Comment 4

[Jessie [:jbonisteel] pls NI]

Glenn, just NI-ing you to get on your radar. Might be hard to move forward with this until we can find consistent STR.

Comment 5

[Timothy Nikkel (:tnikkel)]

I think maybe the base revision of mozilla-central that I was using might explain why this happens only sometimes. I'm going to make a build from from a revision that is a guess of what I was using when this bug was filed and test it.

Comment 6

[Glenn Watson [:gw]]

Sure, I can take a look at this if we have STR.

Comment 7

[Timothy Nikkel (:tnikkel)]

I tried a bunch of old revisions and could not reproduce on any of them. So I guess we go on the theory that this isn't a problem unless/until we see it again?

Comment 8

[Timothy Nikkel (:tnikkel)]

STR in latest nightly on Windows 10:
set:
gfx.webrender.dcomp-win.enabled = false
apz.windows.use_direct_manipulation = true
apz.allow_zooming = true

And use a precision touchpad (To check if your system has one look in Windows Settings, Devices, Touchpad it should say "Your PC has a precision touchpad".) Then pinch zoom almost any page (for example https://www.mozilla.org/en-US/privacy/firefox/ ). You will see no visual change at all until you do something else that causes redrawing (like scrolling).

Comment 9

[Glenn Watson [:gw]]

Is there any way I can reproduce this on a desktop machine that doesn't have a touchpad?

Comment 10

[Timothy Nikkel (:tnikkel)]

Attachment: dmaniplegacymode

I haven't tested it yet but you can try applying this patch (in addition to the STR) and then set mousewheel.with_control.action to 5 and then use mouse wheel + ctrl key pressed.

Failing that you can purchase a usb precision touchpad (which is what I use).

Comment 11

[Jamie Nicol [:jnicol]]

I don't think mouse wheel emulated zooming will work due to bug 1631015.

You could try making this function return true under some state which you can reproduce. Perhaps WHEEL_SCROLL? (Just a guess, I don't know what all those states mean...) It would then hopefully reproduce on scrolling rather than zooming.

Comment 12

[Timothy Nikkel (:tnikkel)]

The attached patch should send PinchGestureInput's into apzc's, so that should be okay then? Ie the mousewheel events only reach our ProcessMessage handler and after that they get intercepted by dmanip code and turned into PinchGestureInput's.

Comment 13

[Glenn Watson [:gw]]

That patch doesn't seem to apply on m-c, and when I try to manually apply it, I get:

 0:18.23 c:/Users/dev/gecko/widget/windows/nsWindow.cpp(5717,11): error: use of undeclared identifier 'mDmViewport'
 0:18.23       if (mDmViewport) {

Followed by a number of similar errors.

Should I need any other local patches? The diff you applied has some printf statements in the context that don't seem to be present either, so I wonder if you have some local changes not in m-c?

Comment 14

[Timothy Nikkel (:tnikkel)]

Sorry about that. After getting the patch working again locally I wasn't able to reproduce the problem without using a precision touchpad, so I think you need a precision touchpad to reproduce.

Comment 15

[Timothy Nikkel (:tnikkel)]

I reproduced the issue on my Surface Pro 2 running Windows 8.1, both with the touchpad and with the touchscreen. When doing the touch screen pinch zoom there are no updates while touching the screen, but upon lifting my fingers the page updates. When using the touchpad there are no updates until you do some other interaction with the page to cause repainting. And the touchscreen issue doesn't need the direct manipulation enabled (which is expected). So the issue also affects touchscreens as well as touchpads (which was a question up until this point).

Comment 16

[Glenn Watson [:gw]]

I have got hold of a touchpad for my Windows desktop, and can reproduce this now - will investigate today.

Comment 17

[Glenn Watson [:gw]]

Attachment: Bug 1632443 - Fix pinch-zoom rendering when partial present is enabled.

WR currently disables picture caching during a pinch-zoom, if the
native compositor is disabled (since there's no real performance
gain to be had from caching tiles during a pinch-zoom).

However, this code path was not returning a dirty rect to the
caller code. For callers that take advantage of partial present,
this meant the screen was assumed to have no changes, and so
the swapbuffers is skipped incorrectly.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/837b1bff6998
Fix pinch-zoom rendering when partial present is enabled. r=sotaro

Comment 19

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/837b1bff6998

Comment 20

[Ciprian Georgiu, Desktop QA]

I was able to reproduce this bug with the steps provided in comment 8, using an affected Nightly build form 2020-04-23.

The issue is not reproducing anymore on dot Release 78.0.1, when using pinch zoom on screen/touch pad. Tested on a Win 10 x64, Dell XPS.