1620055 - (desktop-zoom-nightly) [meta] Enable desktop zooming on the nightly channel

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

This meta bug tracks issues blocking the enablement on desktop zooming by default on the nightly channel.

Comment 1

[Sebastian Zartner [:sebo]]

This should probably be documented at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features once implemented.

Sebastian

Comment 2

[Timothy Nikkel (:tnikkel)]

It's already implemented, so we should document it now I think.

Comment 3

[Sebastian Zartner [:sebo]]

(In reply to Timothy Nikkel (:tnikkel) from comment #2)

It's already implemented, so we should document it now I think.

Then I guess, I misunderstand the feature. What always worked for me is zooming in and out pinching two fingers on the touchpad of my Windows 10 laptop. Switching apz.allow_zooming to true doesn't change that behavior for me.
So could you please shortly explain what the desktop zooming does differently and how it works? That would help a lot to properly describe it on MDN.

Sebastian

Comment 4

[Timothy Nikkel (:tnikkel)]

Currently pinching on a desktop or laptop on a touchpad or touchscreen with do a "reflow zoom" where it zooms in discrete steps and things jump around. This is different from "apz" or "pinch" zoom which currently happens on mobile if you do the pinch gestures on the screen and it is a smooth operation where everything gets bigger without reflowing.

Desktop zooming is to bring this smooth type of zoom to desktop.

If you enable apz.allow_zooming on Windows you will be able to do this smooth pinch zooming if you do the pinch gestures on the touchscreen (if it exists) of your laptop. If you have a laptop with a precision touchpad then you can further enable the pref apz.windows.use_direct_manipulation and that should allow you to do the pinch gesture on your touchpad and have it do the smooth pinch zooming.

Does that all make sense?

Comment 5

[Sebastian Zartner [:sebo]]

Thank you very much for the clarification, Timothy! Unfortunately, my laptop neither has a touch screen nor a precision touchpad (but Dell Touchpad driver), so I can't test it myself right now.

I have added it under https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#desktop-zooming now (taking Firefox 42 as the earliest version, as that was the version that introduced the preference according to bug 1186004).

Sebastian

Comment 6

[Timothy Nikkel (:tnikkel)]

I don't see it on that page now.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

I wasn't seeing it either so I made a no-op change to the page to rebuild it and it shows up now.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1620055 - Turn on allow_zooming on nightly desktop builds. r?ktaeleman

Depends on D85431

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Is it okay to land this with Bug 1654933 unfixed?

Comment 10

[Timothy Nikkel (:tnikkel)]

(In reply to Kagami :saschanaz from comment #9)

Is it okay to land this with Bug 1654933 unfixed?

Are you still seeing bug 1654933? That bug should be "fixed" by bug 1655160 (ie flipping a pref so the code that regressed it is no longer active). I'm leaving the bug open to track a proper fix.

Comment 11

[Kagami Rosylight [:saschanaz] (they/them)]

Ah cool, I'm indeed not seeing the issue anymore. Thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ed6ec0c8220
Turn on allow_zooming on nightly desktop builds. r=ktaeleman

Comment 13

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1620055, Bug 1621740) for causing leaks (DManipEventHandler)

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Gn523SBMSjuDTdyfNSd6yw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=4ed6ec0c8220321b13c108ffaa7ab6cfc8d7698f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311943853&repo=autoland&lineNumber=14316
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311952775&repo=autoland&lineNumber=1777

Backout: https://hg.mozilla.org/integration/autoland/rev/135a148fcdb41e67d97abdafbf11d16cd28f9205

Comment 14

[Timothy Nikkel (:tnikkel)]

Dang, the ownership of DManipEventHandler shouldn't be too complicated. Hopefully not hard to figure out.

Comment 15

[Timothy Nikkel (:tnikkel)]

From the log:

WARNING: mDmManager->Deactivate() failed: file /builds/worker/checkouts/gecko/widget/windows/DirectManipulationOwner.cpp, line 659

That is why it's leaking. Not sure why it's failing though.

Comment 16

[Timothy Nikkel (:tnikkel)]

Moved the dmanip leak to bug 1657073 with fix.

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Thanks! I looked at the autoland push and there as another failure as well, which I've filed bug 1657102 for.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a09e4ce9ebba
Turn on allow_zooming on nightly desktop builds. r=ktaeleman

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Posted to dev-platform and firefox-dev: https://lists.mozilla.org/pipermail/dev-platform/2020-August/025710.html

Comment 20

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a09e4ce9ebba

Comment 21

[Kartikaya Gupta (email:[e-mail])]

Incidentally, metrics showing that now there's a lot of zooming activity on Nightly: https://mzl.la/3iB9rCz

Comment 22

[Chris Mills [:cmills]]

Looks like we have covered this appropriately on https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#UI

So I think the docs for this are completed for now.

Comment 23

[Hamish Willee]

Can you confirm whether or not this ever shipped? I ask because https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#401-419 shows that apz.allow_zooming is true and points to this bug report, even though this the changes here appear to put it in nightly.

The context is that Experimental_features may well be out of date, in particular for https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#desktop_zooming

I'm also interested in whether mobile gesture support went to release: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#mobile_gesture_support_in_responsive_design_mode

Comment 24

[Timothy Nikkel (:tnikkel)]

(In reply to Hamish Willee from comment #23)

Can you confirm whether or not this ever shipped? I ask because https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#401-419 shows that apz.allow_zooming is true and points to this bug report, even though this the changes here appear to put it in nightly.

Yes this shipped a long time ago. There must have been some other bug that flipped the pref beyond nightly.

The context is that Experimental_features may well be out of date, in particular for https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#desktop_zooming

I wouldn't call desktop zooming experimental anymore, it's been shipping for years now.

I'm also interested in whether mobile gesture support went to release: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#mobile_gesture_support_in_responsive_design_mode

I'm not familiar with this but might be better to direct your question to Botond.

Comment 25

[Kartikaya Gupta (email:[e-mail])]

I believe https://bugzilla.mozilla.org/show_bug.cgi?id=1671235 is where this feature was enabled beyond nightly.

Comment 26

[Kartikaya Gupta (email:[e-mail])]

Desktop zooming should definitely no longer be considered experimental. Pretty sure the gestures in RDM should also not be considered experimental but yeah Botond would know better.

Comment 27

[Botond Ballo [:botond]]

+1, both desktop zooming and mobile gesture support in RDM have been shipping for several years and should no longer be considered experimental.

Comment 28

[Hamish Willee]

Thanks very much - appreciate the help! Stripped out in https://github.com/mdn/content/pull/36860