1632531 - Refactor funsize / partials generation for signature check & remove unused code

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Simon Fraser [:sfraser] ⌚️GMT]

Partials generation doesn't correctly check the signing certs, downloads tools and mars multiple times, and could generally be better structured and easier to understand.

Comment 1

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Ensure unique working directory for parallel use.

Bug 1632531 Refactor funsize/partials to remove unused code, add safer checks

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89c68daa3776
Ensure unique working directory for parallel use. r=mtabara

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/89c68daa3776

Comment 4

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1632531 Remove spurious override of make_incremental_update.sh

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73714542e869
Remove spurious override of make_incremental_update.sh r=mtabara

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/1d081d576488
Remove spurious override of make_incremental_update.sh r=mtabara a=aryx

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/73714542e869

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

This caused some issues on b1 Devedition, mainly because Devedition looks like Beta but is signed with the nightly key. But in the refactoring done, we've switched that to release as this failing task depicts: "SIGNING_CERT": "release". The bug is here.

Comment 9

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1632531 - bugfix key verification in partials.r=sfraser,rail

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/902ed66de7da
bugfix key verification in partials.r=sfraser,rail

Comment 11

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 9145628 [details]
Bug 1632531 - bugfix key verification in partials.r=sfraser,rail

Beta/Release Uplift Approval Request

• User impact if declined: Partials in Devedition are currently busted. This addressed an automation fix. If not uplifted, we don't have partials.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 12

[Dorel Luca [:dluca]]

Backed out changeset 902ed66de7da (bug 1632531) for linting failure in gecko/taskcluster/taskgraph/transforms/partials.py. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300758735&repo=autoland&lineNumber=131

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=902ed66de7dafa8247a83fc9e06630100a859efb

Backout:
https://hg.mozilla.org/integration/autoland/rev/0b976ca1f4010d28367c317a8491be9d1b954f8c

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65e475169653
bugfix key verification in partials.r=sfraser,rail

Comment 14

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Dorel Luca [:dluca] from comment #12)

Backed out changeset 902ed66de7da (bug 1632531) for linting failure in gecko/taskcluster/taskgraph/transforms/partials.py. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300758735&repo=autoland&lineNumber=131

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=902ed66de7dafa8247a83fc9e06630100a859efb

Backout:
https://hg.mozilla.org/integration/autoland/rev/0b976ca1f4010d28367c317a8491be9d1b954f8c

Sorry about the bustage, the reviewbot reported too late in the phab request.
I've addressed a follow-up fix and relanded, should be good now.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9145628 [details]
Bug 1632531 - bugfix key verification in partials.r=sfraser,rail

Blocks DevEdition partials from being created. Approved for 77.0b1.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/43c62bc82a33

Comment 17

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/65e475169653