1633287 - Backspace and navigation keys no longer working for recipient input fields

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P1)

Description

[Thomas D. (:thomas8)]

Seen on 77.0a1 (2020-04-26) (64-bit), Win10

Weird and nasty, if someone is able to reproduce this, please confirm!

STR

1. compose, start recipient input for "john"
2. backspace to remove autocomplete suggestion or to correct to "Jane"
3. press any navigation keys to move cursor (cursor left, home, etc.)

Actual result

• backspace does nothing
• navigation keys do nothing

Expected

• remove inline autocomplete suggestion (which is selected)
• then remove last typed character
• maybe both of the above in one go (so as to remove the last typed character immediately)
• for navigation keys, move cursor within input text

This is a regression, probably related to the changes of autocomplete to keydown

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: 1633287-input-field.diff

Silly mistake of preventing the default event when the input is not empty.
Sorry about that.

Comment 3

[Thomas D. (:thomas8)]

Comment on attachment 9143706 [details] [diff] [review]
1633287-input-field.diff

Review of attachment 9143706 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, thanks, this fixes the problem.
There's a similar thing about Ctrl+A which also double-fires now, selecting all pills in all addressing rows prematurely (instead of starting with all pills in current row).

Comment 4

[Alessandro Castellani [:aleca]]

Thanks Thomas.
Can you file a bug for it and assign it to me? I'll take care of it right away.

Comment 5

[Thomas D. (:thomas8)]

(In reply to Alessandro Castellani (:aleca) from comment #4)

Thanks Thomas.
Can you file a bug for it and assign it to me? I'll take care of it right away.

Of course: Bug 1633562. I love that energy!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8f494764f440
Fix backspace and navigation keys issue on recipient input fields. r=mkmelin