1633562 - Ctrl+A from empty recipient input "double-fires" and prematurely selects all rows before current row

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P1)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1633287 +++

Ctrl+A from empty recipient input "double-fires" and prematurely selects all rows before current row.

Similar to bug Bug #1633287 where Alex had to prevent some default events to prevent double-firing on other focus-moving keys. Unfortunately, just adding event.preventDefault in onbeforekeydown() for Ctrl+"a" didn't fix this for me, but I'm confident Alex will figure this out ;-)

Expected (as designed):

• First Ctrl+A from empty input selects all pills in current addressing row
• Next Ctrl+A (with all pills of current row selected, and not event.repeat) conveniently selects all pills of all rows

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1633562-select-all-input.diff

Comment 2

[Thomas D. (:thomas8)]

Comment on attachment 9143799 [details] [diff] [review]
1633562-select-all-input.diff

Review of attachment 9143799 [details] [diff] [review]:
-----------------------------------------------------------------

As I said, I tried the same and thought it should work, but this does not fix it for me.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Screen record from 2020-04-27 14.16.49.gif

This works as intended for me.

Comment 4

[Thomas D. (:thomas8)]

Comment on attachment 9143799 [details] [diff] [review]
1633562-select-all-input.diff

Review of attachment 9143799 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Alessandro Castellani (:aleca) from comment #3)
> This works as intended for me.

It works now for me, too.
Sorry, my mistake, there was something out of sync in my install. Sometimes I feel that the setting "Check for updates, but let me choose whether to install them" is not honoured; instead, it always reverts back to "Automatically install updates".

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/53466469a60f
Prevent double firing CTRL+A on an empty recipient input field. r=mkmelin