Closed Bug 1633838 Opened 4 months ago Closed 4 months ago

Remove Gmail Microphone intervention

Categories

(Web Compatibility :: Interventions, task, P1)

Tracking

(firefox-esr6876+ fixed, firefox75 unaffected, firefox76+ fixed, firefox77+ fixed)

RESOLVED FIXED
Tracking Status
firefox-esr68 76+ fixed
firefox75 --- unaffected
firefox76 + fixed
firefox77 + fixed

People

(Reporter: miketaylr, Assigned: ksenia)

References

Details

Attachments

(2 files)

And update SAO version to 10.1.2.

Pushed by mitaylor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c05ab5081644
Remove Gmail Microphone intervention r=webcompat-reviewers,miketaylr
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED

Comment on attachment 9144087 [details]
Bug 1633838 - Remove Gmail Microphone intervention r=webcompat-reviewers,miketaylr

Requesting uplift to beta + release for folks that have updates disabled.

This patch should be uplifted after Bug 1632947.

Attachment #9144087 - Flags: approval-mozilla-release?
Attachment #9144087 - Flags: approval-mozilla-beta?

Ksenia, can you prep a patch for ESR? We should be sure to remove https://hg.mozilla.org/releases/mozilla-esr68/file/86bb71ceb1817f00260874d6bc2038c4ac43c2a3/mobile/android/extensions/webcompat/injections/js/bug1629926-mail.google.com-hangouts-mic-fix.js (not sure why that's in the mobile addon, since it's useless for mobile).

Flags: needinfo?(kberezina)

Comment on attachment 9144087 [details]
Bug 1633838 - Remove Gmail Microphone intervention r=webcompat-reviewers,miketaylr

Removes the now-unneeded (and problematic) GMail microphone intervention. Effectively a no-op since we're going to be shipping the 10.1.2 SAO update via Balrog to release users anyway. Approved for release to ride-along in any subsequent respins or dot releases as well.

Attachment #9144087 - Flags: approval-mozilla-release?
Attachment #9144087 - Flags: approval-mozilla-release+
Attachment #9144087 - Flags: approval-mozilla-beta?

Comment on attachment 9144347 [details]
Bug 1633838 - ESR - Remove Gmail Microphone intervention r=webcompat-reviewers,miketaylr

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Removes Gmail hangouts intervention that is no longer needed
  • User impact if declined: Users may experience delays with loading email content after receiving mention on google docs
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Low risk. The fix is limited to the webcompat system addon
  • String or UUID changes made by this patch:
Flags: needinfo?(kberezina)
Attachment #9144347 - Flags: approval-mozilla-esr68?
Attachment #9144087 - Flags: approval-mozilla-esr68?

Comment on attachment 9144347 [details]
Bug 1633838 - ESR - Remove Gmail Microphone intervention r=webcompat-reviewers,miketaylr

Approved for ESR68 for whatever release ships next from there (per comment 6, this is effectively a no-op uplift).

Attachment #9144347 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+
Attachment #9144087 - Flags: approval-mozilla-esr68?
You need to log in before you can comment on or make changes to this bug.