Closed Bug 1633903 Opened 5 years ago Closed 3 years ago

Make sure snippets can appear on the cached about:home on startup

Categories

(Firefox :: New Tab Page, task, P3)

Product:
Firefox
Component:
New Tab Page
Type:
task

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: mconley, Unassigned)

References

(Blocks 1 open bug)

Details

We need to make sure that the snippets can appear after the initial about:home load completes.

Priority: -- → P3

It looks like this works out of the box, so I'm closing this as INVALID.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID

I'm less sure now that this is working. I want to test this thoroughly before closing it again.

Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Severity: -- → N/A
Depends on: 1614465

So there's a race here. When loading a cached document, it's (very) possible for the ASRouterUISurface to mount and for the NEWTAB_MESSAGE_REQUEST message to be sent to the parent before the ASRouter module has initted and set up the listener for that message.

bigiri is working on porting ASRouter to using JSWindowActors, which I believe will help sidestep this.

This was fixed by bug 1614465. And then bug 1709984 disabled snippets by default. I think this is a WONTFIX now.

Status: REOPENED → RESOLVED
Closed: 4 years ago → 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.