163404 - when the height of a tree shrinks, we should ensure that the selected row is still visible

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

when I show the message pane (after it has been collapsed), ensure that the 
selected message is still visible in the thread pane.

thanks to martinl for this bug.

Comment 1

[(not reading, please use [e-mail] instead)]

actually, this is a bigger issue.

when the size of the thread pane shrinks, we should ensure that the selected 
message is still visible.

Comment 2

[(not reading, please use [e-mail] instead)]

Note, Outlook Express and NS 4.x does this.

this actually feels like something the tree should do.

jan, is there a way for us to know when the tree is being resized, so we can 
call ensureRowIsVisible()?

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: patch, I'd like jan (or bryner) to review.

Comment 4

[(not reading, please use [e-mail] instead)]

generalizing the bug, adding bryner, so he can comment.

Comment 5

[(not reading, please use [e-mail] instead)]

something I've noticed with this patch is that it makes the thread pane "flash".

It's the same "flashing" you see when currently make the thread pane bigger, 
but now I see it when making it smaller.

Comment 6

[(not reading, please use [e-mail] instead)]

for the flashing problem, see http://bugzilla.mozilla.org/show_bug.cgi?id=163406

Comment 7

[Jan Varga [:janv]]

One thing I noticed with this patch...
Should we really scroll selected index into view if it was note visible before
resizing ?
It looks a bit confusing.

Comment 8

[Martin Lawyer]

It does seem like if the user had specifically scrolled the selected message out
of view, we shouldn't force it back into view 

The original behavior that I noticed was two-fold:  1) after sorting, I have to
scroll looking for my selected message; 2) shrinking the message list window
covered up the messages at the bottom of the list, including any that were
selected.  However, #2 is probably only annoying to people who sort their
messages with the most recent at the bottom of the list (as I do).  

When the list shrinks, the messages are going to either disappear from the top
of the list or the bottom.  Perhaps the choice should be based on which way the
list is sorted. 

How about this: 

1)  if re-sorting the list, the selected message should end up in view  (this I
think should be done, regardless)
2)  if shrinking the message list window, the most recent message header that is
in view should still be in view after resizing? 

I have to admit that #2 is starting to sound like some confusing logic.  Looking
at 4.x, I see their mail window pane works the same way as mozilla (messages at
bottom of list are covered when shrinking the pane). 

Since I was the original complainer, I'd be happy to withdraw my complaint about
#2 if the solution is worse than the problem.  :-)   But I would like to see the
selected message(s) be in view after re-sorting. 

Comment 9

[Jan Varga [:janv]]

It seems that selected message is scrolled into view after resorting.

Comment 10

[(not reading, please use [e-mail] instead)]

> Should we really scroll selected index into view if it was note visible 
before resizing.

I think that's ok.

If I select a message, but manually scroll so it is off screen, resizing will 
bring it back.  I'm fine with that.

outlook express does the same thing.  

the common case is I want the selected message to stay in view (like when I 
resize the whole window or move the splitter.)

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: same patch, plus change for part of the "flashing" problem.

Comment 12

[Jan Varga [:janv]]

Comment on attachment 96245 [details] [diff] [review]
same patch, plus change for part of the "flashing" problem.

r=varga

Comment 13

[Brian Ryner (not reading)]

Comment on attachment 96245 [details] [diff] [review]
same patch, plus change for part of the "flashing" problem.

sr=bryner

Comment 14

[(not reading, please use [e-mail] instead)]

fixed.

Comment 15

[laurel]

OK using nov1 commercial trunk win98,linux rh6.2