1634192 - [MediaControl-Linux] Implement `seek` for MPRIS

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[C.M.Chang[:chunmin]]

We should enable CanSeek for MPRIS if the media is seekable (and media session has an action handler for seekto).

On my Ubuntu 18.04, the seek bar is not enabled by default on the notification bar but it can be tested with a gnome extension like media-player-indicator.

Comment 1

[Marc Streckfuß [:MeFisto94]]

What is the status on the media session side of things for Seeking and Position?

Comment 2

[Alex T]

Attachment: Bug 1634192 - Implement Seek and SetPosition for MPRIS r=#media-playback-reviewers

Comment 3

[C.M.Chang[:chunmin]]

Hey Alex, thanks for the contribution. We'll review this ASAP.

Comment 4

[Alastor Wu [:alwu]]

There are some failures for your patches. You will need to fix them before landing the patches. The instruction of requesting permission is here, I'm happy to vouch you for the L1 permission :) If you have any question, feel free to NI me anytime! Thanks!

Comment 5

[Alastor Wu [:alwu]]

Alex, feel free to let me know when you fix those failures, then I will help you land those patches! Thanks!

Comment 6

[Alex T]

(In reply to Alastor Wu [:alwu] from comment #5)

Alex, feel free to let me know when you fix those failures, then I will help you land those patches! Thanks!

I've fixed the failures related to my changes here, I'm unsure how to address the rest of them though.

Comment 7

[Alastor Wu [:alwu]]

Sorry for my late response. I think the only failure we want to address for your patch is TEST-UNEXPECTED-FAIL | dom/media/mediacontrol/tests/browser/browser_media_control_seek.js. I pushed another task to try and also saw same error.

I will leave my suggestion for that part on the Phabricator later.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9755174e6f6
Implement Seek and SetPosition for MPRIS r=media-playback-reviewers,stransky,alwu,win-reviewers,gstoll

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f9755174e6f6