text in menus and boxes unreadable if using dark GTK theme
Categories
(Core :: Widget: Gtk, defect, P3)
Tracking
()
People
(Reporter: daemonc, Unassigned)
References
Details
(Whiteboard: tpi:+)
Attachments
(7 files)
Comment 1•24 years ago
|
||
Reporter | ||
Comment 3•24 years ago
|
||
Reporter | ||
Comment 5•24 years ago
|
||
Reporter | ||
Comment 6•24 years ago
|
||
Reporter | ||
Comment 9•24 years ago
|
||
Reporter | ||
Comment 11•24 years ago
|
||
Comment 12•23 years ago
|
||
Updated•23 years ago
|
Comment 13•21 years ago
|
||
Updated•20 years ago
|
Comment 14•19 years ago
|
||
Comment 15•17 years ago
|
||
Comment 16•17 years ago
|
||
Comment 17•17 years ago
|
||
Comment 18•17 years ago
|
||
Comment 19•17 years ago
|
||
Comment 20•17 years ago
|
||
Comment 21•17 years ago
|
||
Comment 22•17 years ago
|
||
Assignee | ||
Updated•17 years ago
|
Updated•16 years ago
|
Comment 23•16 years ago
|
||
Comment 24•16 years ago
|
||
Comment 25•15 years ago
|
||
Updated•12 years ago
|
Comment 26•11 years ago
|
||
Comment 27•10 years ago
|
||
Comment 28•10 years ago
|
||
Comment 29•10 years ago
|
||
Comment 30•9 years ago
|
||
Comment 31•9 years ago
|
||
Comment 32•9 years ago
|
||
Comment 33•9 years ago
|
||
Updated•8 years ago
|
Comment hidden (advocacy) |
Comment 35•7 years ago
|
||
Comment 36•7 years ago
|
||
Comment 37•7 years ago
|
||
Comment 38•7 years ago
|
||
Comment 39•7 years ago
|
||
Comment 40•7 years ago
|
||
Comment 41•7 years ago
|
||
Comment 42•7 years ago
|
||
Comment 43•7 years ago
|
||
Comment 44•7 years ago
|
||
Comment 46•7 years ago
|
||
Comment 47•7 years ago
|
||
Comment 48•6 years ago
|
||
Comment 49•6 years ago
|
||
Comment 50•6 years ago
|
||
Comment 51•6 years ago
|
||
I hit this bug today by choosing the dark Adwaita theme in Gnome 3.28 and Firefox 65.0. It's amazing that this is an 18 year old bug. I found it surprising the system theme did anything to webpages and had two consecutive surprises:
- First setting the system theme to Adwaita-dark changed the Firefox theme. That makes sense. What was surprising was that the Firefox theme then changed the content of the web pages. My mental model of a browser is that within the page view it's a different world and there's no reason for the web to look different to match the browser chrome or the system theme.
- Because I didn't actually like the dark version of Firefox I switched it to the Light theme manually (webpages are usually light colored and so dark chrome in browsers looks weird). And yet even after doing this pages still had dark buttons and input areas. That was even stranger. Now Firefox had a light theme and yet the webpages were still picking up broken colors from the system theme inconsistent with the Firefox chrome theme.
I fixed this after some web searches by setting "widget.content.gtk-theme-override:Adwaita". That at least sets a light theme for UI controls and is back to looking reasonable. I found that in bug #1283086 which seems to be a 3 year old duplicate of this 18 year old bug. The proposal for removal of all native theming in #1411425 makes perfect sense.
Comment 52•6 years ago
|
||
In the mean time, could widget.content.gtk-theme-override
be set to Adwaita
by default? This would fix the issue (except for the settings page), and Adwaita is always present on systems with GTK+. I opened https://bugzilla.mozilla.org/show_bug.cgi?id=1527048 for this change, everyone please go comment on that bug :)
So I think it would be useful to know, for the current round of complaints, are the problems the result of:
- Firefox incorrectly gets data out of the GTK theme, so that its default appearance for controls doesn't match the native one, or
- Firefox gets the data out of the theme correctly, but then web pages override one but not both of color and background (while assuming that color is dark and background is light), leading to an unreadable result
We've had both problems in the past, and it would be useful to know which of them is happening in the set of problems that have spiked in the past few months.
Comment 54•6 years ago
|
||
I use this extension as a workaround: fix-dark-theme-input-boxes (source)
Comment 55•6 years ago
|
||
David: The problem here is point 2. Just setting widget.content.gtk-theme-override
to Adwaita
by default would fix this for web pages, but the General -> Startup section of the Settings page still looks wrong (white text on a white background), along with a couple of other spots in Settings, despite setting this pref.
Comment 56•6 years ago
|
||
If you uncheck "Use System Colors" it's no longer a problem.
Comment 57•6 years ago
|
||
I have "Use System Colors" unchecked, widget.content.gtk-theme-override
set to Adwaita
and the Light theme selected. And yet even then the Ctrl-F input has white text over white background.
re comment 57, with those settings (on Ubuntu 18.04), I see white text on a dark background.
Comment 59•6 years ago
|
||
I'm also using Ubuntu 18.04 but using the vanilla GNOME session (that uses Wayland) with the dark Adwaita theme selected. Could you please test with that to see if you get the same result?
Comment 60•6 years ago
|
||
System colors (and it's override) is covered by Bug 1422563
Dark Gtk theme is covered by Bug 1527048
Comment 61•6 years ago
|
||
btw. widget.content.gtk-theme-override should be set to "Adwaita:light" and works only when e10s is enabled.
Comment 62•6 years ago
|
||
I seem to have e10s enabled:
Multiprocess Windows 1/1 Enabled by default
and have set Adwaita:light:
widget.content.gtk-theme-override;Adwaita:light
I still get white text on white background on the Find textbox within webpages.
Comment 63•6 years ago
|
||
Here's a simple way to replicate this bug for me. In both cases I have the Light theme selected:
$ GTK_THEME="Adwaita:dark" firefox
(firefox runs and the Find box has white text on white background)
$ GTK_THEME="Adwaita:light" firefox
(firefox runs and the Find box has the correct black text on white background)
Comment 64•6 years ago
|
||
This should be fix as of https://bugzilla.mozilla.org/show_bug.cgi?id=1527048#c14
Testing appreciated.
Comment 65•6 years ago
|
||
Can this be resolved fixed due to Bug 1527048 being fixed?
Updated•6 years ago
|
Comment 66•6 years ago
|
||
Yes, duplicate of Bug 1527048.
Description
•