1634479 - [wpt-sync] Sync PR 23341 - Add a test to check the video detector helper function.

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23341 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23341
Details from upstream follow.

Harald Alvestrand <[e-mail]> wrote:

Add a test to check the video detector helper function.

This also checks that the video luma settles to a reasonable value
for a large range of values, so could be considered a codec test.
WPT bug: https://github.com/web-platform-tests/wpt/issues/23340

Bug: none
Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608
Reviewed-on: https://chromium-review.googlesource.com/2172971
WPT-Export-Revision: 7c2fe7afdf6a9f9fe76550795af08bc48651ab33

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 23341 applied with additional changes from upstream: 0de19dc97fb8a46fc83c95153da7bbffb7018c54, a9f1e8c01979f0415e4f18396fa7b46d257a675a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=186e9fa3034bbda19eb4eb11abd785ab57ea2e98

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 162 tests and 1 subtests

## Status Summary

### Firefox
OK                 : 69[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] 72[Gecko-windows7-32-debug, Gecko-windows7-32-opt] 73[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] 84[GitHub]
PASS               : 774[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] 818[GitHub] 872[Gecko-windows7-32-debug, Gecko-windows7-32-opt] 882[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt]
FAIL               : 296[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 297[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] 424[GitHub]
PRECONDITION_FAILED: 1
TIMEOUT            : 9[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 19[GitHub]
ERROR              : 1[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 3[GitHub]
NOTRUN             : 10[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 18[GitHub]

### Chrome
OK                 : 87
PASS               : 1091
FAIL               : 138
TIMEOUT            : 13
ERROR              : 2
NOTRUN             : 35

### Safari
OK                 : 78
PASS               : 689
FAIL               : 441
TIMEOUT            : 25
ERROR              : 6
NOTRUN             : 127

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=186e9fa3034bbda19eb4eb11abd785ab57ea2e98)
[GitHub PR Head](https://wpt.fyi/results/?sha=aa4f1774a4e67d0950a807184c31690c95e8efc9&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=aa4f1774a4e67d0950a807184c31690c95e8efc9&label=pr_base)

## Details

### Firefox-only Failures
/html/dom/usvstring-reflection.https.html
  source : unpaired surrogate codepoint should be replaced with U+FFFD: FAIL
  anchor : unpaired surrogate codepoint should be replaced with U+FFFD: FAIL
  area : unpaired surrogate codepoint should be replaced with U+FFFD: FAIL
  storage event : unpaired surrogate codepoint should be replaced with U+FFFD: FAIL
/webrtc/protocol/video-codecs.https.html
  H.264 and VP8 should be negotiated after handshake: FAIL linked bug:Bug 1534687
  H.264 and VP8 should be supported in initial offer: FAIL linked bug:Bug 1534688
  All H.264 codecs MUST include profile-level-id: FAIL linked bug:Bug 1534687
/webrtc/RTCConfiguration-rtcpMuxPolicy.html
  setConfiguration(config) - with { rtcpMuxPolicy: 'invalid' } should throw TypeError: FAIL
  setRemoteDescription throws InvalidAccessError when called with an answer without rtcp-mux and rtcpMuxPolicy is set to require: FAIL
  new RTCPeerConnection({ rtcpMuxPolicy: undefined }) should have default rtcpMuxPolicy require: FAIL
  new RTCPeerConnection({ rtcpMuxPolicy: 'require' }) should succeed: FAIL
  new RTCPeerConnection({ rtcpMuxPolicy: 'negotiate' }) may succeed or throw NotSupportedError: FAIL
  new RTCPeerConnection(config) - with { rtcpMuxPolicy: 'invalid' } should throw TypeError: FAIL
  setConfiguration({ rtcpMuxPolicy: 'require' }) with initial rtcpMuxPolicy negotiate should throw InvalidModificationError: FAIL
  setConfiguration(config) - with { rtcpMuxPolicy: null } should throw TypeError: FAIL
  setRemoteDescription throws InvalidAccessError when called with an offer without rtcp-mux and rtcpMuxPolicy is set to require: FAIL
  setConfiguration({}) with initial rtcpMuxPolicy negotiate should throw InvalidModificationError: FAIL
  setConfiguration({ rtcpMuxPolicy: 'negotiate' }) with initial rtcpMuxPolicy require should throw InvalidModificationError: FAIL
  new RTCPeerConnection() should have default rtcpMuxPolicy require: FAIL
  new RTCPeerConnection(config) - with { rtcpMuxPolicy: null } should throw TypeError: FAIL
/webrtc/RTCPeerConnection-connectionState.https.html: SKIP [`Gecko-android-em-7.0-x86_64-debug-geckoview`, `Gecko-android-em-7.0-x86_64-opt-geckoview`, `Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-qr-opt`, `Gecko-windows10-64-debug`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-debug`, `Gecko-windows10-64-qr-opt`, `Gecko-windows7-32-debug`, `Gecko-windows7-32-opt`], TIMEOUT [`GitHub`]
  Initial connectionState should be new: FAIL
  connectionState transitions to connected via connecting: TIMEOUT
  connection with one data channel should eventually have connected connection state: TIMEOUT
  Closing the connection should set connectionState to closed: FAIL
  Closing a PeerConnection should not fire connectionstatechange event: NOTRUN
/mst-content-hint/idlharness.window.html
  MediaStreamTrack interface: videoTrack must inherit property "contentHint" with the proper type: FAIL
  MediaStreamTrack interface: attribute contentHint: FAIL
  MediaStreamTrack interface: audioTrack must inherit property "contentHint" with the proper type: FAIL
/webrtc/RTCPeerConnection-track-stats.https.html: SKIP [`Gecko-android-em-7.0-x86_64-debug-geckoview`, `Gecko-android-em-7.0-x86_64-opt-geckoview`, `Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-qr-opt`, `Gecko-windows10-64-debug`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-debug`, `Gecko-windows10-64-qr-opt`, `Gecko-windows7-32-debug`, `Gecko-windows7-32-opt`], TIMEOUT [`GitHub`]
  RTCRtpSender.getStats() contains only outbound-rtp and related stats: TIMEOUT
  RTCRtpReceiver.getStats() contains only inbound-rtp and related stats: NOTRUN
  O/A exchange yields inbound RTP stream stats for receiving track: FAIL
  O/A exchange yields outbound RTP stream stats for sending track: FAIL
  addTrack() without setLocalDescription() yields track stats: FAIL
  RTCPeerConnection.getStats(receivingTrack) is the same as RTCRtpReceiver.getStats(): NOTRUN
  RTCPeerConnection.getStats(sendingTrack) is the same as RTCRtpSender.getStats(): NOTRUN
  addTrack() with setLocalDescription() yields track stats: FAIL
/webrtc/idlharness.https.window.html
  RTCRtpTransceiver interface: operation setCodecPreferences(sequence<RTCRtpCodecCapability>): FAIL
  RTCPeerConnection interface: new RTCPeerConnection() must inherit property "setConfiguration(optional RTCConfiguration)" with the proper type: FAIL
  RTCIceCandidate interface: attribute candidate: FAIL
  RTCDTMFSender interface: attribute canInsertDTMF: FAIL
  RTCRtpReceiver interface: calling getCapabilities(DOMString) on new RTCPeerConnection().addTransceiver('audio').receiver with too few arguments must throw TypeError: FAIL
  RTCPeerConnection interface: attribute onconnectionstatechange: FAIL
  RTCIceTransport interface object length: FAIL
  RTCPeerConnection interface: attribute connectionState: FAIL
  RTCIceTransport interface: attribute gatheringState: FAIL
  RTCRtpReceiver interface: operation getCapabilities(DOMString): FAIL
  RTCRtpSender interface: calling getCapabilities(DOMString) on new RTCPeerConnection().addTransceiver('audio').sender with too few arguments must throw TypeError: FAIL
  RTCRtpSender interface: operation getCapabilities(DOMString): FAIL
  RTCIceTransport interface: attribute state: FAIL
  RTCIceTransport interface: existence and properties of interface prototype object's @@unscopables property: FAIL
  RTCCertificate interface: idlTestObjects.certificate must inherit property "getFingerprints()" with the proper type: FAIL
  RTCIceTransport interface: existence and properties of interface prototype object's "constructor" property: FAIL
  RTCRtpTransceiver interface: new RTCPeerConnection().addTransceiver('audio') must inherit property "setCodecPreferences(sequence<RTCRtpCodecCapability>)" with the proper type: FAIL
  RTCCertificate interface: operation getFingerprints(): FAIL
  RTCRtpReceiver interface: new RTCPeerConnection().addTransceiver('audio').receiver must inherit property "getParameters()" with the proper type: FAIL
  RTCRtpReceiver interface: operation getParameters(): FAIL
  RTCPeerConnection interface: new RTCPeerConnection() must inherit property "onconnectionstatechange" with the proper type: FAIL
  RTCRtpTransceiver interface: calling setCodecPreferences(sequence<RTCRtpCodecCapability>) on new RTCPeerConnection().addTransceiver('audio') with too few arguments must throw TypeError: FAIL
  RTCRtpSender interface: calling setParameters(RTCRtpSendParameters) on new RTCPeerConnection().addTransceiver('audio').sender with too few arguments must throw TypeError: FAIL
  RTCIceTransport interface object name: FAIL
  RTCIceCandidate interface: attribute sdpMLineIndex: FAIL
  RTCIceCandidate interface: attribute sdpMid: FAIL
  RTCPeerConnection interface: calling setConfiguration(optional RTCConfiguration) on new RTCPeerConnection() with too few arguments must throw TypeError: FAIL
  RTCPeerConnection interface: new RTCPeerConnection() must inherit property "connectionState" with the proper type: FAIL
/webrtc/protocol/ice-ufragpwd.html
  setRemoteDescription with a ice-ufrag containing a non-ice-char fails: FAIL
  setRemoteDescription with a ice-pwd containing a non-ice-char fails: FAIL
/webrtc/RTCPeerConnection-setRemoteDescription-pranswer.html
  setRemoteDescription(answer) from have-remote-pranswer state should succeed: FAIL
  setRemoteDescription(pranswer) multiple times should succeed: FAIL
  setRemoteDescription(pranswer) from stable state should reject with InvalidStateError: FAIL
  setRemoteDescription(pranswer) from have-local-offer state should succeed: FAIL
/webrtc/RTCPeerConnection-setLocalDescription-pranswer.html
  setLocalDescription(answer) from have-local-pranswer state should succeed: FAIL
  setLocalDescription(pranswer) can be applied multiple times while still in have-local-pranswer: FAIL
/webrtc/RTCPeerConnection-getStats.https.html
  getStats() with no argument should return stats report containing peer-connection stats on an empty PC: FAIL

(See attachment for full changes)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a269ce5b1da
[wpt PR 23341] - Add a test to check the video detector helper function., a=testonly
https://hg.mozilla.org/integration/autoland/rev/511d61706ba5
[wpt PR 23341] - Update wpt metadata, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0a269ce5b1da
https://hg.mozilla.org/mozilla-central/rev/511d61706ba5