1634585 - Android implementation of mozilla::GetProcInfo returns nullptr

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, defect, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

None of the calling code expects this. We should either write a minimal implementation or at the very least unconditionally create and reject a promise.

Comment 1

[Ian Moody [:Kwan] (UTC+1)]

Dupe of bug 1529510?

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Not a dupe. Don't get me wrong, we definitely need to implement bug 1529510. But this stubbed-out API should be returning a rejected promise, not nullptr.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

...and we now have crashes in the wild as a result of this.

Comment 4

[Randall Barker [:rbarker]]

FxR is seeing this crash in the latest release.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1634585: Return a rejected promise instead of nullptr from mozilla::GetProcInfo on Android; r=#geckoview-reviewers

This is a simple fix to eliminate crashing. Proper implementation of this
function will be done in bug 1529510.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78e1e47675dc
Return a rejected promise instead of nullptr from mozilla::GetProcInfo on Android; r=geckoview-reviewers,agi

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/78e1e47675dc

Comment 8

[Benjamin Beurdouche [:beurdouche]]

Attachment: Bug 1634585 - Set CKA_NSS_SERVER_DISTRUST_AFTER for Trustis FPS Root CA. r=kjacobs,jcj

Comment 9

[(No longer employed by Mozilla) Aaron Klotz]

I think you've got the wrong bug number for this patch :-)

Comment 10

[Benjamin Beurdouche [:beurdouche]]

Off by one, sorry about that : )

Comment 11

[Phabricator Automation]

Comment on attachment 9166907 [details]
Bug 1634585 - Set CKA_NSS_SERVER_DISTRUST_AFTER for Trustis FPS Root CA. r=kjacobs,jcj

Revision D85330 was moved to bug 1634584. Setting attachment 9166907 [details] to obsolete.

Comment 12

[Chris Peterson [:cpeterson]]

Moving isolated process bugs to the new GeckoView::Sandboxing component.