1634691 - Return early in Page.navigate for all non-http traffic

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect, P1)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

It already returns early for data: and about: schemes, so this just expands the condition.

Otherwise the command times out because the current implementation is waiting for events that don't occur in these cases.

This at least makes the command usable for file:// etc while follow-up bugs get fixed (such as Bug 1634690)

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

While writing a test for file urls, I saw RemoteAgent.close() hit an error in test teardown because a destructor was unable to look up the id of a target to clean up. For some reason, that target did not have a browsing context id. (Perhaps it wasn't fully initialized after file:// navigation?)

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300284517&repo=try&lineNumber=4798

Excerpt:

RemoteAgent	ERROR	unable to stop listener: TypeError: can't access property "id", this.browsingContext is null(chrome://remote/content/targets/TabTarget.jsm:55:5) JS Stack trace: get [e-mail]:55:5
[e-mail]:104:5
[e-mail]:114:12
[e-mail]:115:22
[e-mail]:90:25
Async*Tester_execTest/<@browser-test.js:1039:34
async*[e-mail]:1074:11
nextTest/<@browser-test.js:904:14
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@SimpleTest.js:918:23
!!! could not start server on port 9222: [Exception... "Component returned failure code: 0x804b0036 (NS_ERROR_SOCKET_ADDRESS_IN_USE) [nsIServerSocket.init]"  nsresult: "0x804b0036 (NS_ERROR_SOCKET_ADDRESS_IN_USE)"  location: "JS frame :: chrome://remote/content/server/HTTPD.jsm :: _start :: line 567"  data: no]
1588278702525	RemoteAgent	ERROR	unable to stop listener: [Exception... "Unexpected error"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://remote/content/server/HTTPD.jsm :: stop :: line 621"  data: no] Stack trace: stop()@HTTPD.jsm:621
close()@RemoteAgent.jsm:119
asyncListen()@RemoteAgent.jsm:100

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1634691 - Decouple Target id from browsing context id

This fixes exceptions hit in destructors when the browsing context
is null.

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1634691 - Return early in Page.navigate for all non-http traffic

Depends on D73459

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6253f484818a
Decouple Target id from browsing context id r=remote-protocol-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/c3478c000960
Return early in Page.navigate for all non-http traffic r=remote-protocol-reviewers,whimboo

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6253f484818a
https://hg.mozilla.org/mozilla-central/rev/c3478c000960