1549475 - [meta] Page.navigate

Status: RESOLVED WORKSFORME

(Remote Protocol :: CDP, task)

Comment 1

[David Burns :automatedtester]

Closing as all dependencies appear to be done

Comment 2

[Andreas Tolfsen ❲:ato❳]

There are parameters we don’t implement which we don’t have bugs for,
so it’s probably wise to leave these meta bugs open in perpetuity.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mind filing those bugs, so that it is clear from the dependency tree what still has to be done?

Comment 4

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #3)

Mind filing those bugs, so that it is clear from the dependency
tree what still has to be done?

We have a meta bug for each command and event, but beyond that it’s
hard to tell upfront how the implementation work will be structured.

In some cases it makes sense to implement command parameters
individually as one, logical chunk (for example Page.navigate’s
ignoreCache). But frequently you might cover several parameters,
if not all, when you add support for a command. It’s also not given
that we want to implement everything that CDP does, so I think this
by necessity has to be approached on a case-by-case basis.

In the case of Page.navigate, there’s referrer, transitionType,
and frameId, but we haven’t run into cases in the Gutenberg- or
Puppeteer test suites that require them yet.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I assume closing this bug was not the expected thing to do. As you say while everything we need to get puppeteer-mvp done has been implemented, some parts haven't been done yet. As such we should keep this bug open but remove it as blocker for puppeteer-mvp.

The remaining work to do is actually related to the return object, which doesn't have the loaderId and errorText implemented. Everything else seems to be done meanwhile.

Comment 6

[Andreas Tolfsen ❲:ato❳]

Can you please point to some data that loaderId and errorText
is consumed by Puppeteer?

I believe this is the metric we use to determine if a bug be closed,
which was at the request of product management to keep track
of progress on this project.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For the MVP and specifically the Gutenberg tests the following bug are necessary:

• bug 1543095
• bug 1549786

Both have direct dependencies to bug 1539202 setup. So we don't need the dependency setup again for this meta bug. Also puppeteer example will get direct dependencies.

As such this bug stays open for the remaining work to do maybe in next year.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Everything that we could do for CDP is done.