163572 - converting string is inserted every hitting space key

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Shotaro Kamio]

IME converting string is inserted repeatedly every hitting space key.

Steps to reproduce:
1. Open a page which have textareas like this page.
2. Click on blank area (not on textarea).
3. Turn on IME.
4. Type some string. e.g. "kanji"
5. Click on textarea.
6. Hit space key to convert.
-> you'll see that converting string is inserted every hitting space key.

Comment 1

[Shotaro Kamio]

Japanese Bugzilla has descriptions about this bug in japanese.
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=2515
Followings are the summary.

In my disgnosis,
nsEditor::mInIMEMode (a flag indicates IME on/off) is confusing in this bug.
Because we turn IME on not in textarea but in blank area.
So, CreateTxnForInsertText() is executed.
We should execute CreateTxnForIMEText().
http://lxr.mozilla.org/seamonkey/source/editor/libeditor/base/nsEditor.cpp#2362

The solution is to prevent us from turing IME on/off at un-editable area.
For it, we should check widget is editable/un-editable when move the focus.

Comment 2

[Hidehiro Kozawa]

OS is all.
at least in win32, same phenomenon is appeared.

at least, in win32 environment,
if hitting key that is mentioned step '6.' in original comment is not only space
key but also next(another) charactor, strings are also inserted repeatedly.

Comment 3

[Hidehiro Kozawa]

There are IME useful function 'Find As You Type', 'Link find' and etc.

>The solution is to prevent us from turing IME on/off at un-editable area.
has problems accordingly.
If we cannot use IME in all un-editable area, we cannot find text we need IME
for. That is a regression.
Browser window must be IME able area.

This bug occur Japanese IME at least.

#korean IME seem not to have this bug.

I hope that this bug will become 'ASSIGNED' earlier.

Comment 4

[Hidehiro Kozawa]

If I click out of textarea during composition in textarea, text of textarea
become composition end.

I think that If I click textarea during composition in 'Find As You Type', we
must send end of composition message OS(IME).

Comment 5

[Hidehiro Kozawa]

Idea 1:
When we call nsWindow::ResetInputState() everytime after non textarea lost focus
for other widget of this apprication instance get focus.

Idea 2:
When we call nsEditor::ForceCompositionEnd() everytime after textarea get caret.

Comment 6

[Hidehiro Kozawa]

Oh Idea2 has problem.
>Idea 2:
>When we call nsEditor::ForceCompositionEnd() everytime after textarea get caret.

It is problem that calling nsEditor::ForceCompositionEnd() when menubar get
focus and textarea get focus again.

Comment 7

[Hidehiro Kozawa]

Attachment: first patch idea

ForceCompositonEnd Idea.
This is a way fix this bug.
I test it.

I want to call only clear Composition functon Instead of ForceComposisionEnd to
clear unwanted　compositon string.

Comment 8

[Hidehiro Kozawa]

Kamio says #1,
>nsEditor::mInIMEMode (a flag indicates IME on/off) is confusing in this bug.
a flag indicates IME on Composion or not,
This case, nsEditor::StartCompositon not excuse, but status is on composition,
that mismatch cause this bug.

Comment 9

[Hiro]

This bug was not reproduced by Mozilla Firebird.
And it reproduced by Camino.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.7a) Gecko/20040210
Firebird/0.8.0+

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.7a) Gecko/20040211
Camino/0.7+

Comment 10

[Hidehiro Kozawa]

Still reproduced WinXP.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040210
Firebird/0.8.0+

Comment 11

[Hidehiro Kozawa]

Attachment: idaa: clear the text

we also need to edit non windows's nsWindow.cpp...

Comment 12

[Mike Pinkerton (not reading bugmail)]

*** Bug 234617 has been marked as a duplicate of this bug. ***

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: patch for nsIKBStateControl

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: patch for cocoa(not implemented)

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: patch for gtk(not implemented)

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: patch for mac(not implemented)

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: patch for photon(not implemented)

Comment 18

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: patch for windows

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: patch for editor

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: patch for editor(-u8pw)

Comment 21

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

These patch fixes this bug for Windows only.
Because the |CancelIMEComposition| of nsIKBStateControl is implemented on
Windows only.

On this concept, when the editor gets focus, the editor destruction the IME
composition string.

Comment 22

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: patch for nsIKBState Control

Sorry. the comment is my mistake.

Comment 23

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 162816 [details] [diff] [review]
patch for mac(not implemented)

you need to do widget/src/cocoa in addition to widget/src/mac.

r+ on mac, but it'll break camino if you don't do cocoa.

Comment 24

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 162814 [details] [diff] [review]
patch for cocoa(not implemented)

my bad, you did do cocoa, i just didn't see it at first glance. sorry!!

r=pink

Comment 25

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 162815 [details] [diff] [review]
patch for gtk(not implemented)

pavlov:

Please review this patch.

Comment 26

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 162819 [details] [diff] [review]
patch for editor

sfraser:

Please superreview too.

Comment 27

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: patch for check-in

Thank you for all reviewers and superreviewers.

Jungshik:
Would you check-in this patch?

Comment 28

[Jungshik Shin]

patch checked into trunk

Comment 29

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

*** Bug 169076 has been marked as a duplicate of this bug. ***