Closed Bug 1635939 Opened 3 months ago Closed 3 months ago

Support "auto | <ratio>" syntax for aspect-ratio

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: boris, Assigned: boris)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(3 files)

Bug 1547231 introduced aspect-ratio property, and the current spec uses auto | <ratio> syntax on apect-ratio. The wpt is also updated by Chrome. So it's time to update its syntax.

Status: NEW → ASSIGNED

In order to test its parsing and serialization, we expose it but protect
it behind a pref.

Attachment #9147770 - Attachment description: Bug 1635939 - let aspect-ratio support 'auto | <ratio>'. → Bug 1635939 - Let aspect-ratio support 'auto | <ratio>'.
Attachment #9147770 - Attachment description: Bug 1635939 - Let aspect-ratio support 'auto | <ratio>'. → Bug 1635939 - Let aspect-ratio (css-sizing-4) support 'auto | <ratio>'.

Also, we drop the pref, layout.css.aspect-ratio-number.enabled, becacuse
the spec of css-sizing-4 uses Number now.

Keywords: dev-doc-needed
Blocks: 1639689
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/950700804199
Let aspect-ratio (css-sizing-4) support 'auto | <ratio>'. r=emilio
https://hg.mozilla.org/integration/autoland/rev/23f534aec8fa
Replace AspectRatio with computed::position::Ratio in media-queries. r=emilio
https://hg.mozilla.org/integration/autoland/rev/131702da23a1
Use style::One for Integer to avoid implementing Mul. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23725 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged by moz-wptsync-bot
Blocks: 1640036
You need to log in before you can comment on or make changes to this bug.