1636673 - when a search term has "/" as the first character, upon pressing enter the address bar prepends "http:/" and visits a website instead of searching

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[1hsan]

Attachment: 16-09-11.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

typed /a (or any alpha character following a slash) in the address bar.

Actual results:

the address bar prepended http/ before my search string and appended a slash. upon pressing enter a website (e.g. www.a.com) was visited.

Expected results:

the search strings should have been submitted to the search engine.

Comment 1

[1hsan]

Comment on attachment 9147006 [details]
16-09-11.mp4

dropbox link for video: https://www.dropbox.com/s/j3z17x7lckmp7mp/16-09-11.mp4?dl=0

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[1hsan]

also happens when an alpha character followed by a slash is typed in the address bar. https://www.dropbox.com/s/seao4bfy4jd5wcc/19-35-08.mp4?dl=0

Comment 4

[Firefox Bug Husbandry Bot]

Because this bug's Severity is normal and has not been changed, and this bug's priority is -- (none,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 5

[Marco Bonardo [:mak]]

I think this is because Services.io.newURI("http:///a").spec == "http://a/". URIFixup::fixupURIProtocol takes the original strings, adds "http://" in front and checks whether it's a valid uri, and in this case it is valid. That's of course sub-optimal.

Comment 6

[Marco Bonardo [:mak]]

fixed by bug 1398567.

Comment 7

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using Fx78.0RC and Fx79.0a1 on windows. Typing /word now correctly triggers a search.
On ubuntu and macOS however this is not case. Typing /a prompts the browser to open a file.
@Marco Is the fix intended only for windows?

Comment 8

[Marco Bonardo [:mak]]

yes, on Unix systems /something is a valid file url