1637916 - Update the "Mozilla Foundation" greeting that Thunderbird prints on startup

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Kai Engert (:KaiE:)]

On initial startup, Thunderbird shows a notification bar saying "Thunderbird is free and open source software from the non-profit Mozilla Foundation".

Ryan, does this need to be changed?
If yes, can you suggest a new text?

Comment 1

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/search?q=notifyRightsText&path=

In the about:rights it's (after bug 1567070) going to be "Thunderbird is free and open source software, built by a community of thousands from all over the world." to match Firefox. (I don't know if they have this particular notification bar though.)

Comment 2

[Kai Engert (:KaiE:)]

Should this get fixed before the string freeze?

Comment 3

[Kai Engert (:KaiE:)]

Attachment: 1637916-v1.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9152394 [details] [diff] [review]
1637916-v1.patch

Review of attachment 9152394 [details] [diff] [review]:
-----------------------------------------------------------------

We should move right to Fluent here. 
(An example of how is https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#928-929,958-960,989-990)

But once bug lands we can just use the "rights-intro" string we have in there. I would defer this bug until then.

::: mail/locales/en-US/chrome/messenger/aboutRights.properties
@@ +3,5 @@
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  buttonLabel=Know your rights…
>  buttonAccessKey=K
>  # LOCALIZATION NOTE (notifyText): %S will be replaced by brandFullName from brand.properties

The original was also wrong, but this should be (notifyRightsText)

Comment 5

[Kai Engert (:KaiE:)]

(In reply to Magnus Melin [:mkmelin] from comment #4)

But once bug lands

Did you intend to include a bug number of a related bug?

we can just use the "rights-intro" string we have in
there.

That string contains an additional sentence "There are a few things you should know::"

If you use that string, you'd get a longer text, and in addition you'll get the button which says "Know your rights…"

Is that what you want?

I would defer this bug until then.

Defer until when? You suggest that we do nothing now, prior to the string freeze?

Comment 6

[Magnus Melin [:mkmelin]]

Sorry, bug 1567070. I think we need to land that before the string freeze.
But you're right, we should add this new string into that file too.

Comment 7

[Kai Engert (:KaiE:)]

Attachment: debug-helper.patch

just for my reference, debug change to always show the notice in debug builds

Comment 8

[Kai Engert (:KaiE:)]

It's not clear how quickly 1567070 will land.
IIUC you want this one to wait until bug 1567070 is done.

Comment 9

[Kai Engert (:KaiE:)]

If you want the modified string to be included in the new ftl file from bug 1567070, then I cannot yet work on this.

If another revision for bug 1567070 is needed, maybe Khushil could include this change, too?

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: bug1637916_update_knowyourrights_notification.patch

Looking at it again, this text is for the 3pane and should not to into the about rights fluent file.

Comment 11

[Kai Engert (:KaiE:)]

Comment on attachment 9153014 [details] [diff] [review]
bug1637916_update_knowyourrights_notification.patch

You no longer need brandBundle in showAboutRightsNotification.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/530f652a7c34
Update the showAboutRightsNotification greeting that Thunderbird prints on startup. r=kaie