1638609 - "Find More Add-ons" button opens ATN in external browser

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect, P1)

Description

[Andrei Hajdukewycz [:sancus]]

Attachment: screenshot of discovery pane

The "Find More Add-ons" button at the bottom of the new Discovery Pane is broken. It should open ATN in a new tab(inside Thunderbird). Previously, it opened the link in an external browser, which is also wrong.

The following error shows in the error console:
Uncaught
Exception { name: "NS_ERROR_ILLEGAL_VALUE", message: "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIExternalProtocolService.loadURI]", result: 2147942487, filename: "chrome://communicator/content/contentAreaClick.js", lineNumber: 230, columnNumber: 0, data: null, stack: "openLinkExternally@chrome://communicator/content/contentAreaClick.js:230:6\nopenUILinkIn@chrome://communicator/content/contentAreaClick.js:253:21\nopenTrustedLinkIn@chrome://communicator/content/contentAreaClick.js:267:15\nopenAmoInTab@chrome://mozapps/content/extensions/aboutaddons.js:4462:26\nhandleEvent@chrome://mozapps/content/extensions/aboutaddons.js:4180:21\nEventListener.handleEventconnectedCallback@chrome://mozapps/content/extensions/aboutaddons.js:4172:12\nshow@chrome://mozapps/content/extensions/aboutaddons.js:4569:10\nasyncshow@chrome://mozapps/content/extensions/extensions.js:557:41\nasyncloadViewInternal@chrome://mozapps/content/extensions/extensions.js:451:27\nloadInitialView@chrome://mozapps/content/extensions/extensions.js:388:10\nloadInitialViewFn@chrome://mozapps/content/extensions/extensions.js:497:21\ninitialize@chrome://mozapps/content/extensions/aboutaddons.js:4511:10\ngetHtmlBrowser/_htmlBrowserLoaded<@chrome://mozapps/content/extensions/extensions.js:531:33\npromise callbackgetHtmlBrowser@chrome://mozapps/content/extensions/extensions.js:530:7\ninitialize@chrome://mozapps/content/extensions/extensions.js:551:23\ninitialize@chrome://mozapps/content/extensions/extensions.js:272:12\ninitialize@chrome://mozapps/content/extensions/extensions.js:51:19\nEventListener.handleEvent*@chrome://mozapps/content/extensions/extensions.js:24:10\n", location: XPCWrappedNative_NoHelper }
contentAreaClick.js:230

Comment 1

[Magnus Melin [:mkmelin]]

I think bug 1638092 will fix it. Opening links on trunk is kind of broken atm.

Comment 2

[Andrei Hajdukewycz [:sancus]]

(In reply to Magnus Melin [:mkmelin] from comment #1)

I think bug 1638092 will fix it. Opening links on trunk is kind of broken atm.

Will that also fix the issue of it trying to open in external browser though? I guess we'll have to see, and I'll morph this bug if it doesn't. I originally started filing this to report it not opening in a TB tab, which is a big problem for 78 because that button is the only way, other than a search, to get to ATN now.

Comment 3

[Andrei Hajdukewycz [:sancus]]

So, yeah. Bug 1638092 fixed the brokenness of the link, but now it opens in external browser again. It needs to open in Thunderbird so that people can actually install add-ons.

Comment 4

[Magnus Melin [:mkmelin]]

Quickly looking at this I think it ends up in openAmoInTab and from there https://searchfox.org/comm-central/rev/9498b3d1accf12df749f19b88fb1d0a1fcad8d4d/mail/base/content/contentAreaClick.js#256

(If not, something with openContentTab?)

I notice the Privacy Policy link below is also wrong (linking to non-openable chrome://). This should be fixable by setting a extensions.recommendations.privacyPolicyUrl value in all-thunderbird.js

Comment 5

[Khushil Mistry [:khushil324]]

Adding an extensions.recommendations.privacyPolicyUrl in all-thunderbird.js worked. It is now opening up the privacy policy in the browser. Do we want to open it in the Thunderbird? What URL should we put there? Firefox is putting: https://www.mozilla.org/privacy/firefox/?utm_source=firefox-browser&utm_medium=firefox-browser&utm_content=privacy-policy-link#addons

Comment 6

[Khushil Mistry [:khushil324]]

How about this: https://www.mozilla.org/en-US/privacy/thunderbird/#addons?

Comment 7

[Andrei Hajdukewycz [:sancus]]

(In reply to Khushil Mistry [:khushil324] from comment #6)

How about this: https://www.mozilla.org/en-US/privacy/thunderbird/#addons?

That seems fine for now, the privacy policy is being currently rewritten anyway so we may need to change this link in a future release.

E: Oh and I think it's fine if the privacy policy link opens in external browser. Only links to ATN are supposed to always open in Thunderbird.

Comment 8

[Khushil Mistry [:khushil324]]

Attachment: Bug-1638609_fix-reco-addon-links-0.patch

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9157713 [details] [diff] [review]
Bug-1638609_fix-reco-addon-links-0.patch

Review of attachment 9157713 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/23275377fdbe
fix add-ons discovery pane "find more addons" and privacy links. r=mkmelin

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9157713 [details] [diff] [review]
Bug-1638609_fix-reco-addon-links-0.patch

Needed to get a couple of links working in the new add-ons discovery pane.

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9157713 [details] [diff] [review]
Bug-1638609_fix-reco-addon-links-0.patch

Approved for beta

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 78.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/3c83aafae22f