1639107 - Port bug 1638153 to Thunderbird: Fix JS users of rootTreeItem

Status: RESOLVED FIXED

(Thunderbird :: General, task, P1)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1638153 +++

We should do what https://phabricator.services.mozilla.com/D75429 does.

https://searchfox.org/comm-central/search?q=rootTreeItem.domWindow&path=mail&case=false&regexp=false

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1639107-fix-rootTreeItem.patch

This is a port of https://hg.mozilla.org/integration/autoland/rev/ba4656e730c4.

I haven't tested it, I only converted all docShell.rootTreeItem.domWindow to browsingContext.topChromeWindow.

Comment 2

[Richard Marti (:Paenglab)]

Tested it now and all works.

With and without the patches in m-c and c-c I see following error:
Uncaught TypeError: can't access property "QueryInterface", aWebProgress is null
onProgressChange chrome://messenger/content/tabmail.js:593

Do you know what this is? Do you see this too?

Comment 3

[Magnus Melin [:mkmelin]]

Looks like bug 1646483 - loads of tests failing.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9157377 [details] [diff] [review]
1639107-fix-rootTreeItem.patch

Review of attachment 9157377 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b17c821d89c9
Port bug 1638153 part 2: Fix uses of .rootTreeItem to get top browser window. r=mkmelin

Comment 6

[Magnus Melin [:mkmelin]]

An automated test could extend this, to try to open the dialog.
https://searchfox.org/comm-central/rev/38c93f8c99cfe10cff5cd1b0ce399ff2334c0003/mail/test/browser/account/browser_actions.js#102