163912 - clicking link in label also activates form element

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect, P3)

Description

[Jesse Ruderman]

Clicking a link inside a <label> element also activates the form element.  For a
textarea, it just focuses the textarea, but for a checkbox, it checks or
unchecks the box.  Neither the HTML 4 spec nor the w3c validator disallows links
inside labels.

Comment 1

[rods (gone)]

->

Comment 2

[John Keiser (jkeiser)]

Looks to me like this is fixed (WinXP 2002121008), can you retest?

Comment 3

[John Keiser (jkeiser)]

Attachment: Testcase

This is a more minimal testcase.  Clicking on the label does not click the
corresponding checkbox.

Comment 4

[Jesse Ruderman]

Attachment: better testcase

The original testcase used name= where it should have used id=, so the <label
for=blah> wasn't pointing to the checkbox.  

With this new testcase, I still see the bug in Mozilla 12/23 on Windows XP.

Comment 5

[Jesse Ruderman]

Back to jkeiser (assuming you got reassigned to nobody because you couldn't
reproduce).

Comment 6

[Boris Zbarsky [:bzbarsky]]

This should basically be fixed by the event stuff jkeiser's working on, no?

Comment 7

[John Keiser (jkeiser)]

Yeah, probably.  Setting dependent on that bug.  It does bring something up
though: obviously the label is not preventing default when it sends the click
on, and it really should.  However, until we reverse the flow of default
actions, that will only make this situation worse.  What should really happen is
the link should just be clicked.

Comment 8

[Chris Casciano]

hate to poke a bug, but *poke*

this has come up in conversation, and it also appears on camino (trunk) and
deerpark OS X so updating hardware/OS

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to comment #8)
> hate to poke a bug, but *poke*
> 
> this has come up in conversation, and it also appears on camino (trunk) and
> deerpark OS X so updating hardware/OS

Poke probably has no effect. 

FYI - The owner of record [e-mail] is inactive it seems.  Perhaps someone is watching all his assignments but it's impossible to tell from the bug.  Of 117 or so bugs assigned, only a couple got meaningful comments (from anyone) in the past year.

What may be needed is a new champion and action on Bug 185758.  If no one replies here (and no one has) you might check developer IRC to see if anything is in progress or planned.

FWIW, assigning to default owner.

Comment 10

[zug_treno]

*** Bug 327683 has been marked as a duplicate of this bug. ***

Comment 11

[Wayne Mery (:wsmwk)]

(In reply to comment #0)
> Clicking a link inside a <label> element also activates the form element.  ....  
> Neither the HTML 4 spec nor the w3c validator disallows links inside labels.

works same in IE.

Comment 12

[Edward Welker]

Does not work the same in IE (7), nor Opera. 

This bug needs more attention... it's a major accessibility problem.

Comment 13

[Edward Welker]

Attachment: Very simple test case demonstrating the problem.

Comment 16

[kitchin]

Attachment: Screenshot of a.m.o.

Also affects the current layout of addons.mozilla.org.

Checkbox "Let me install this experimental add-on" is unexpectedly checked by clicking "What's this?"

Comment 17

[kitchin]

The a.m.o. problem is Bug 530194.

Comment 18

[Robin Whittleton]

Is this still a problem? In Edward Welker’s testcase (https://bug163912.bmoattachments.org/attachment.cgi?id=308365) the checkbox doesn’t change checked state when the link is clicked.

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S4. However, the bug has 3 duplicates.
:emilio, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.