530194 - "Let me install this experimental add-on" checked by "What's this?" link in label

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[kitchin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.6pre) Gecko/20091120 Shiretoko/3.5.6pre
Build Identifier: 

Experimental add-ons have a checkbox to allow installation. Just clicking "What's this?" enables installation.

The '</label>' close tag should be moved up in the following HTML:

<label>
 <input type="checkbox"
  id="confirm-6623"/>Let me install this experimental add-on. <a href="/en-US/firefox/pages/faq#experimental-addons">What's this?</a>
</label>

Created by: http://viewvc.svn.mozilla.org/vc/addons/trunk/site/app/views/helpers/install_button.php?annotate=53267&pathrev=53267#l297 due to Bug 495309.

See also: Bug 487177 Comment 2. All relevant bugs are now closed but the issue is not fixed.

By the way, Firefox's behavior on links within labels of form element differs from IE and Opera, see Bug 163912.


Reproducible: Always

Steps to Reproduce:
1. Go to an experimental extension at a.m.o, such as the URL above.
2. Click "What's this?"

Actual Results:  
Checks nearby checkbox, lighting up the graphic and enabling installation.

Expected Results:  
Let me decide whether to enable installation.

Comment 1

[Ryan Doherty (:rdoherty)]

Attachment: v1

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 414335 [details] [diff] [review]
v1

I don't like the idea of splitting up that string, but I can see why.

Comment 3

[Ryan Doherty (:rdoherty)]

(In reply to comment #2)
> (From update of attachment 414335 [details] [diff] [review])
> I don't like the idea of splitting up that string, but I can see why.

Yeah, I didn't want to either, but couldn't think of a better way.

r56807

Comment 4

[krupa raj[:krupa]]

STR:
1.Go to https://addons.mozilla.org/en-US/firefox/browse/type:1/cat:72?show=20&exp=on&sort=newest
2.Select the option to show experimental addons
3.Click on the "What's this?" link

expected result:
The user navigates to FAQ page where description of experimental addons is made available.The install button is not enabled.

Actual result:
The install button is enabled and the user then navigates to the description page

screencast:http://screencast.com/t/NjQ1Y2I1

Reopening...

Comment 5

[Ryan Doherty (:rdoherty)]

This hasn't been pushed live yet, it's fixed on preview.

Comment 6

[krupa raj[:krupa]]

my bad.This is fixed.

Comment 7

[kitchin]

Attachment: Screen shot of spacing issue

After fix, there is no space between the two sentences. Need some whitespace after '</label>'.

Comment 8

[kitchin]

Re-opening for the polish issue, lack of space between sentences.

Comment 9

[Wil Clouser [:clouserw]]

This is a priority 1 bug from a previous release (meaning, it won't show up in queries for current or future releases).  For a trivial thing like a space please file a new bug.

Comment 10

[kitchin]

OK thanks, Bug 534563 filed.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.