Open Bug 1639954 Opened 5 years ago Updated 2 years ago

Make sure the alertfinished notification will fire if an observer is passed to the nsIAlertsService when suppressing during screen sharing

Categories

(Toolkit :: Alerts Service, defect, P2)

Product:
Toolkit
Component:
Alerts Service
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- unaffected
firefox77 --- affected
firefox78 --- affected

People

(Reporter: mconley, Unassigned)

References

(Blocks 1 open bug)

Details

Bug 1635257 added a new attribute on the nsIAlertsDoNotDisturb interface that allows the underlying service to silence notifications when sharing the screen over WebRTC.

According to the documentation for the alerts service, the alertfinished notification should fire for a passed in observer if the alert is not going to display. We should make sure we do that.

I was trying to review for this but maybe I missed a case.

If we are doing this so web developers are aware the notification wasn't shown then maybe we should be communicating this via APIs to show the notification rather than using the close event since that won't really tell developers why/how it was closed?

Severity: -- → S4
status-firefox76: --- → unaffected
status-firefox77: --- → affected
status-firefox78: --- → affected
status-firefox-esr68: --- → unaffected
Priority: -- → P2
Blocks: 1642799
No longer blocks: 1639879
Group: mozilla-employee-confidential
Component: Notifications and Alerts → Alerts Service
You need to log in before you can comment on or make changes to this bug.