Closed Bug 1641427 Opened 4 months ago Closed 4 months ago

startup Crash in [@ mozilla::SandboxBroker::LaunchApp]

Categories

(MailNews Core :: General, defect, P1)

Unspecified
Windows 10

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 78.0

People

(Reporter: t.matsuu, Assigned: kershaw)

References

(Regression)

Details

(Keywords: crash, regression, topcrash-thunderbird)

Crash Data

Attachments

(1 file)

This bug is for crash report bp-93074412-2c14-4cbd-bf36-ab6400200528.
Build ID: 20200527191555
Version: Thunderbird 78.0a1 win64

Top 10 frames of crashing thread:

0 xul.dll mozilla::SandboxBroker::LaunchApp security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp:298
1 xul.dll mozilla::ipc::WindowsProcessLauncher::DoLaunch ipc/glue/GeckoChildProcessHost.cpp:1576
2 xul.dll mozilla::ipc::BaseProcessLauncher::PerformAsyncLaunch ipc/glue/GeckoChildProcessHost.cpp:1017
3 xul.dll mozilla::detail::ProxyRunnable<mozilla::MozPromise<mozilla::ipc::LaunchResults, mozilla::ipc::LaunchError, 0>, RefPtr<mozilla::MozPromise<mozilla::ipc::LaunchResults, mozilla::ipc::LaunchError, 0> >  xpcom/threads/MozPromise.h:1433
4 xul.dll mozilla::TaskQueue::Runner::Run xpcom/threads/TaskQueue.cpp:212
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1211
6 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:501
7 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:332
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308
9 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290

Product: Thunderbird → MailNews Core
Duplicate of this bug: 1641443

I doubt we could ship next week's beta 78 with a crash of this magnitude

Severity: -- → S1
Summary: Crash in [@ mozilla::SandboxBroker::LaunchApp] → startup Crash in [@ mozilla::SandboxBroker::LaunchApp]
Version: unspecified → 78

Pretty sure this is the windows 100% startup crash Richard tracked down - from bug 1602832 (starting from the first patch there)

Regressed by: 1602832
Priority: -- → P1

Richard, are you able to verify that? Insert this before that line:

printf("xxx targetInfo=%d\n", !!targetInfo);

If it shows 0 this is the problem.

Alternatively, if this bug is about timing, could dllSvc be null?

Richard confirmed in matrix both targetInfo and dllSvc are ok.
I guess we're not getting the full stack then. Maybe it's failing at https://searchfox.org/mozilla-central/source/mozglue/dllservices/WindowsDllServices.h#68

OH, that is the case, the crash report says MOZ_CRASH Reason (Sanitized): MOZ_RELEASE_ASSERT(mInitDllBlocklistOOPFnPtr)

But I don't know why it's not on the stack.

Any idea what needs changing?

Flags: needinfo?(kershaw)

(In reply to Magnus Melin [:mkmelin] from comment #8)

Any idea what needs changing?

I think we can disable socket process for Thunderbird before I figure out the root cause.

I think the proper way to fix this is calling DllServicesBase::EnableFull before launching socket process, but I have no idea why this is not called.

Flags: needinfo?(kershaw)
Assignee: nobody → kershaw
Status: NEW → ASSIGNED

Could you also help to verify if disabling socket process can fix this crash?
Thanks.

Assignee: kershaw → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(mkmelin+mozilla)
Assignee: nobody → kershaw

I don't have a proper test setup for this myself, but Richard can reproduce and will check if this fixes it.

Flags: needinfo?(mkmelin+mozilla) → needinfo?(richard.marti)

This patch works for me. TB starts again. Many thanks.

Flags: needinfo?(richard.marti)
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd3da1642381
Disable socket process for thunderbird r=mkmelin

Hi,
I updated TB daily just now , and recieved all times a crash.
I cannnot start or restart TB daily any more: creating a new profile doesnt help.

bp-094b8eb0-886a-490c-af07-1480c0200528 vor 1 Minute
bp-61d6db14-194a-4b85-ab9e-29a640200528 vor 3 Minuten
bp-f3bdd5c2-908e-4c61-a156-05b2d0200528 vor 3 Minuten
bp-936b0636-f028-4bd9-8e8d-d92800200528 vor 4 Minuten
bp-0d43cb2a-9c7d-4e7f-851d-063390200528 vor 4 Minuten
bp-003ebf80-a141-40ec-b08e-64e200200528 vor 5 Minuten

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 78.0
Duplicate of this bug: 1642002

I downloaded thunderbird-79.0a1.en-US.win64.installer.exe (to install BuildID 20200604105934)
for updating from not startable Thunderbird 78.0a1, BuildID 20200528103753.
After Updating there was no mailprofile anymore but a error message at startup handled in bug 1643285 .

Duplicate of this bug: 1642717
You need to log in before you can comment on or make changes to this bug.