1642303 - ourworldindata graph not shown

Status: VERIFIED FIXED

(Core :: DOM: Networking, defect, P1)

Description

[Arthur]

Attachment: Firefox nightly not showing ourworldindata graph

Since a few days the current nighlties don't show the graph in
(https://ourworldindata.org/grapher/total-covid-deaths-per-million?tab=chart&time=2020-03-15..&country=ARG~AUT~BEL~BRA~CAN~CHN~DNK~FRA~DEU~IRL~ITA~JPN~LIE~LUX~NLD~PRT~RUS~KOR~ESP~SWE~CHE~GBR~USA)
isn't shown. A different profile or private browsing don't help. Chrome displays the graph correctly.

Comment 1

[Mike Taylor [:miketaylr]]

ncaught (in promise) Error: 0 
    Wt https://ourworldindata.org/assets/js/commons.js:16
    Wt https://ourworldindata.org/assets/js/commons.js:16
    Wt https://ourworldindata.org/assets/js/commons.js:16
    xt https://ourworldindata.org/assets/js/commons.js:16
    xt https://ourworldindata.org/assets/js/commons.js:16
    Wt https://ourworldindata.org/assets/js/commons.js:16
    downloadData https://ourworldindata.org/assets/js/commons.js:36
    M https://ourworldindata.org/assets/js/commons.js:36
    M https://ourworldindata.org/assets/js/commons.js:36
    downloadData https://ourworldindata.org/assets/js/commons.js:36
    ne https://ourworldindata.org/assets/js/commons.js:16
    r https://ourworldindata.org/assets/js/commons.js:16
    ne https://ourworldindata.org/assets/js/commons.js:16
    r https://ourworldindata.org/assets/js/commons.js:16
    b https://ourworldindata.org/assets/js/commons.js:16
    m https://ourworldindata.org/assets/js/commons.js:16
    runReaction https://ourworldindata.org/assets/js/commons.js:16
    We https://ourworldindata.org/assets/js/commons.js:16
    Ye https://ourworldindata.org/assets/js/commons.js:16
    Ye https://ourworldindata.org/assets/js/commons.js:16
    js https://ourworldindata.org/assets/js/commons.js:64
    Ye https://ourworldindata.org/assets/js/commons.js:16
    He https://ourworldindata.org/assets/js/commons.js:16
    schedule https://ourworldindata.org/assets/js/commons.js:16
    it https://ourworldindata.org/assets/js/commons.js:16
    P https://ourworldindata.org/assets/js/commons.js:36
    bootstrap https://ourworldindata.org/assets/js/commons.js:36
    <anonymous> https://ourworldindata.org/grapher/total-covid-deaths-per-million?tab=chart&time=2020-03-15..&country=ARG~AUT~BEL~BRA~CAN~CHN~DNK~FRA~DEU~IRL~ITA~JPN~LIE~LUX~NLD~PRT~RUS~KOR~ESP~SWE~CHE~GBR~USA:56
commons.js:16:59596

So, it looks like this is failing in an xhr request:

function Wt(e) {
return xt(this, void 0, void 0, function * () {
return new Promise((t, n) =>{
const r = new XMLHttpRequest;
r.addEventListener('load', function () {
t(JSON.parse(this.responseText))
}),
r.addEventListener('readystatechange', () =>{
4 === r.readyState && 200 !== r.status && n(new Error(`${r.status
}
 ${r.statusText
}
`))
}),
r.open('GET', e),
r.send()
})
})
}

Comment 2

[Mike Taylor [:miketaylr]]

9:09.33 INFO: Last good revision: 741feae54c0f0a339b32ba05b4f71dc50c830fc6
9:09.33 INFO: First bad revision: 2bccc3e80006f2ad27060453135b19fac2d43460
9:09.33 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=741feae54c0f0a339b32ba05b4f71dc50c830fc6&tochange=2bccc3e80006f2ad27060453135b19fac2d43460

Interesting... enabling rel=preload breaks this page. Honza, any idea why this might happen (I haven't really looked closely).

Note to the reporter: right now this change won't ship to release, but it will be broken in Nightly until we can figure it out.

Comment 3

[Alin Ilea, Desktop QA]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Hi,

I have managed to reproduce this issue on Beta 78.0b3 and latest Nightly 79.0a1 (2020-06-05) using Windows 10 as well. I will move this over to a component, but if this is not the correct component please feel free to change it to an appropriate one.

Thanks.

Comment 4

[Honza Bambas (:mayhemer)]

Attachment: Bug 1642303 - Accept missing HTTP channel in XHR when preload has already been done and mChannel is thus missing to prevent silent send() error, r=baku

Comment 5

[Honza Bambas (:mayhemer)]

Attachment: Bug 1642303 - Keep channel of FetchPreloader even after the load has finished to let preload consumers use that channel early after opening, r=baku

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03baebbd4fb0
Keep channel of FetchPreloader even after the load has finished to let preload consumers use that channel early after opening, r=baku

Comment 7

[Honza Bambas (:mayhemer)]

Comment on attachment 9155023 [details]
Bug 1642303 - Keep channel of FetchPreloader even after the load has finished to let preload consumers use that channel early after opening, r=baku

Beta/Release Uplift Approval Request

• User impact if declined: Broken high profile website.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low, because only thing that this could is a leak that we would likely catch on try. Try run was leak-free.
• String changes made/needed:

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/03baebbd4fb0

Comment 10

[Alin Ilea, Desktop QA]

Reproduced the issue using an old Nightly build 79.0a1 (2020-06-05) and Beta 78.0b5.
Verified - Fixed in latest Nightly build 79.0a1 (build id: 20200612094620) using Windows 10 and Ubuntu 18.04.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9155023 [details]
Bug 1642303 - Keep channel of FetchPreloader even after the load has finished to let preload consumers use that channel early after opening, r=baku

rel=preload will be off in the next 78 beta build.

Comment 14

[Florin Strugariu [:Bebe]]

== Change summary for alert #26195 (as of Fri, 12 Jun 2020 14:46:59 GMT) ==

Improvements:

4% raptor-tp6-instagram-firefox-cold loadtime windows10-64-shippable-qr opt 1,227.00 -> 1,181.08

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26195