Closed Bug 1642489 Opened 5 years ago Closed 5 years ago

Remove sidebar from brand files

Categories

(SeaMonkey :: Sidebar, task)

Product:
SeaMonkey
Component:
Sidebar
Type:
task

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.77
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.4)

Attachments

(1 file)

Just use sidebar rather than brand entities
9.28 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Sidebar is not really a "brand" anymore and the use of the "brand" was inconsistent, so probably best to just remove (as pointed out by frg).

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.4
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 2 strings removed, 6 strings amended

Attachment #9153257 - Flags: review?(frgrahl)
Attachment #9153257 - Flags: approval-comm-release?
Attachment #9153257 - Flags: approval-comm-esr60?
Comment on attachment 9153257 [details] [diff] [review] Just use sidebar rather than brand entities LGTM
Attachment #9153257 - Flags: review?(frgrahl)
Attachment #9153257 - Flags: review+
Attachment #9153257 - Flags: approval-comm-release?
Attachment #9153257 - Flags: approval-comm-release+
Attachment #9153257 - Flags: approval-comm-esr60?
Attachment #9153257 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/65cc83747662
Remove sidebar from brand files. r=frg

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: