Closed
Bug 1642489
Opened 4 years ago
Closed 4 years ago
Remove sidebar from brand files
Categories
(SeaMonkey :: Sidebar, task)
SeaMonkey
Sidebar
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
RESOLVED
FIXED
seamonkey 2.77
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.4)
Attachments
(1 file)
|
9.28 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Sidebar is not really a "brand" anymore and the use of the "brand" was inconsistent, so probably best to just remove (as pointed out by frg).
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.4
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 2 strings removed, 6 strings amended
Attachment #9153257 -
Flags: review?(frgrahl)
Attachment #9153257 -
Flags: approval-comm-release?
Attachment #9153257 -
Flags: approval-comm-esr60?
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9153257 [details] [diff] [review] Just use sidebar rather than brand entities LGTM
Attachment #9153257 -
Flags: review?(frgrahl)
Attachment #9153257 -
Flags: review+
Attachment #9153257 -
Flags: approval-comm-release?
Attachment #9153257 -
Flags: approval-comm-release+
Attachment #9153257 -
Flags: approval-comm-esr60?
Attachment #9153257 -
Flags: approval-comm-esr60+
|
|
||
Updated•4 years ago
|
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → affected
tracking-seamonkey2.53:
--- → ?
tracking-seamonkey2.57esr:
--- → ?
Whiteboard: SM2.53.4
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/65cc83747662
Remove sidebar from brand files. r=frg
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
|
|
||
Updated•4 years ago
|
Target Milestone: --- → seamonkey 2.77
|
|
||
Comment 4•3 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a6296faf3fa79ad152de6b5dc9bb4d8d7a9b86f5
Remove sidebar from brand files. r=frg a=frg
Target 2.53.4
You need to log in
before you can comment on or make changes to this bug.
Description
•