Closed Bug 1642450 Opened 4 years ago Closed 4 years ago

Use vendorURL for the throbber

Categories

(SeaMonkey :: Build Config, task)

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.77
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.4)

Attachments

(1 file, 1 obsolete file)

As the throbber URL is now used across all window types, it probably needs renaming from browser.throbber.url
To match similar prefs, I'm suggesting app.throbberURL and, whilst we're at it, let's put it in brand.properties

Depends on: 1641354
Attached patch Rename and move throbber url (obsolete) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.3
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 1 addition, 1 removal

Attachment #9153220 - Flags: review?(frgrahl)
Attachment #9153220 - Flags: approval-comm-release?
Attachment #9153220 - Flags: approval-comm-esr60?
Blocks: 1641390
Blocks: 1642462
Blocks: 1642489

As point out by frg on irc, no point having two almost identical entities so let's just use app.vendorURL for the throbber.

Summary: Rename throbber URL and move to brand.properties → Use vendorURL for the throbber

r/a=frg over irc

Attachment #9153220 - Attachment is obsolete: true
Attachment #9153220 - Flags: review?(frgrahl)
Attachment #9153220 - Flags: approval-comm-release?
Attachment #9153220 - Flags: approval-comm-esr60?
Attachment #9160204 - Flags: review+
Attachment #9160204 - Flags: approval-comm-release+
Attachment #9160204 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/7240535ea3af
Use vendorURL for the throbber. r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.4
Target Milestone: --- → seamonkey 2.77
You need to log in before you can comment on or make changes to this bug.