1642510 - Cannot switch between reader mode popups with one click

Status: RESOLVED WORKSFORME

(Toolkit :: Reader Mode, defect, P5)

Description

[Mathew Hodson]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

1. Go to https://getpocket.com/explore/item/why-do-dogs-love-us-science-explains
2. Press F9 to toggle reader view
3. Click the icon for type controls
4. Hover over the icon for narration controls
5. Click the narrate icon

Actual results:

The popup closes and that's it.

Expected results:

The narration icon should respond to the cursor hovering over it even while the other popup is open. Clicking the icon should open the narration popup.

Comment 1

[Mathew Hodson]

Last good revision: 300f86134b707b102caf4cac8758c4485986eb7f
First bad revision: 8f9d7916be0157d299f1b88a4a09ae8fbff334b3
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=300f86134b707b102caf4cac8758c4485986eb7f&tochange=8f9d7916be0157d299f1b88a4a09ae8fbff334b3

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[:Gijs (he/him)]

This was a deliberate part of the design in bug 1637652. I don't think there's a real point to changing it given that practically speaking, you're unlikely to want to switch from one of these dropdowns to the other because they're completely orthogonal to each other.

If we did we'd have to deal with other issues, like the tooltips indicating what the buttons do being obscured by open popups (they don't show right now because the toolbar isn't getting any hover events), and it would bring back bug 1638223 (so we'd need some other fix for that). The current behaviour matches what other web apps do, e.g. slack's actions on messages and the popups from those behave the same way.

Comment 4

[Mathew Hodson]

This was fixed in bug 1655402, and the controls now have the expected behaviour.