1644084 - After deleting contact from search results in contacts sidebar, entire result set disappears

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1619157 +++

STR

1. composition with contacts side bar, ensure "All Address Books" is shown
2. Filter for "Doe" so that you get a couple of matches in the search result
3. select and delete a contact from search result (contact originates from "Personal AB")
4. press DEL and confirm deletion, then monitor the rest of your result set in results pane
5. Try other variants:

• delete contact from "All Address Books" without search filter
• delete contact from "Personal AB" with and without search filter
• try all variants with deleting a mailing list

Actual result

• deleting contact from search result of "All ABs" succeeds, but makes the entire result set disappear (blank results pane)
• deleting contact from unfiltered "Personal AB" ends up with a bogus icon-only item at the end of the list which cannot be deleted.
• deleting mailing list sometimes failed

Expected:

• delete/remove only selected items
• keep showing any other items (of result set, or current AB)
• handle focus after deletion

Comment 1

[Alice0775 White]

Before the regression window:
#1 if last item is deleted in the sidebar list, a blank item is remained.
#2 if middle item is deleted in the sidebar list, last item is visually duplicated.

After the regression window:
All items disappear in the sidebar list.

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=c5def570bb4b97b043bf35eda9df5f08fe996109&tochange=96995bd8f55c685952d95b51fdb1c0a8f10c05a9
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ead8f0367372fe5767d33a0aa0a95b07ee76ea75&tochange=19e273db80195cc5de59647fcaf16bafad9bbcce

Suspect: Bug 1636019

Comment 2

[Thomas D. (:thomas8)]

Thank you Alice!!
So we can remove regressionwindow-wanted because you found it.

Together with similar bug 1644026, that makes contacts side bar quite broken...

Comment 3

[Thomas D. (:thomas8)]

Geoff, from your experience in Bug 1639750, any insights here?

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1644084-delete-selected-cards-1.diff

This call to SetABView() is bogus, we should never call that without arguments. Fortunately all of this block of code is redundant because ABView.deleteSelectedCards does the same thing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/926e7403d2a8
Remove redundant code for deleting contacts. r=rjl

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9160566 [details] [diff] [review]
1644084-delete-selected-cards-1.diff

I want this bad UX to be fixed in 78.1.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9160566 [details] [diff] [review]
1644084-delete-selected-cards-1.diff

Approved for 79 beta, to prepare for 78

Comment 8

[Geoff Lankow (:darktrojan)]

Thunderbird 79.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/c311f8f7c4a8

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9160566 [details] [diff] [review]
1644084-delete-selected-cards-1.diff

Approved for esr78 (low risk)

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.0.1:
https://hg.mozilla.org/releases/comm-esr78/rev/2d38f5830c8a