1644248 - Mouse Back/Forward break in Responsive Design Mode

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P2)

Description

[lancehmd]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Open Responsive Design Mode (Ctrl+Shift+M), try to use Back or Forward buttons on a mouse.

Actual results:

Nothing.

Expected results:

Go one page forward or one page back.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Micah [:mtigley] (she/her)]

Thank you for reporting this issue! I can confirm this is also reproducible on Firefox Nightly 79 and Firefox Developer Edition 78 when the pref: devtools.responsive.browserUI.enabled = false. I'll investigate.

Comment 3

[Micah [:mtigley] (she/her)]

Attachment: Bug 1644248 - Fallback on RemoteWebNavigation's method for navigating backward/forward.

Comment 4

[Micah [:mtigley] (she/her)]

Attachment: Bug 1644248 - Duplicate test for browser_navigation.js to be run against browserUI pref set to false.

Depends on D78835

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53433ac7ae94
Fallback on RemoteWebNavigation's method for navigating backward/forward. r=bradwerth
https://hg.mozilla.org/integration/autoland/rev/014940ce9ff5
Duplicate test for browser_navigation.js to be run against browserUI pref set to false. r=bradwerth

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1644248) for causing dt failures in browser_old-rdm_navigation.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=014940ce9ff5c051fc387bd2f71c8a6f244d7df0&selectedTaskRun=RdTxMuiLTjaqKEcOY9j5sw-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305724192&repo=autoland&lineNumber=1099

Backout: https://hg.mozilla.org/integration/autoland/rev/247bc42758fad4a6f190dc9eafcedbc8e1382847

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/573a96c80046
Fallback on RemoteWebNavigation's method for navigating backward/forward. r=bradwerth
https://hg.mozilla.org/integration/autoland/rev/093ce2a6ea7b
Duplicate test for browser_navigation.js to be run against browserUI pref set to false. r=bradwerth

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/573a96c80046
https://hg.mozilla.org/mozilla-central/rev/093ce2a6ea7b

Comment 10

[Micah [:mtigley] (she/her)]

Comment on attachment 9155156 [details]
Bug 1644248 - Fallback on RemoteWebNavigation's method for navigating backward/forward.

Beta/Release Uplift Approval Request

• User impact if declined: Navigating forward/back in RDM will not work for users and will make the tool appear broken.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch contains small and relatively trivial changes.
• String changes made/needed: no

Comment 11

[Alin Ilea, Desktop QA]

Reproduced the initial issue in Beta 78.0b5 (build id: 20200609215727).
Verified - Fixed in latest Nightly build 79.0a1 (build id: 20200611093454) using Windows 10 and Ubuntu 18.04.

Comment 12

[Julien Cristau [:jcristau]]

I guess you meant to request uplift to beta (78)? Is this a regression? What caused it?

Comment 13

[Micah [:mtigley] (she/her)]

(In reply to Julien Cristau [:jcristau] from comment #12)

I guess you meant to request uplift to beta (78)? Is this a regression? What caused it?

Would it be possible to uplift the fix to release (77)? This issue is only reproducible when the pref devtools.responsive.browserUI.enabled is false and Firefox Release 77 is the only build where this is the case.

I was also able to narrow the regression to Bug 1614462. So this issue has been around for a few months already and our tests were not sufficient enough to catch this. The tests added here will fix this.

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 9155156 [details]
Bug 1644248 - Fallback on RemoteWebNavigation's method for navigating backward/forward.

No, we just merged 78 to mozilla-release ahead of next week's release, so 77 won't see an update anymore.