1644612 - Languages selection window keep growing when adding new languages, buttons disappear

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement, P3)

Description

[[e-mail]]

Attachment: bug firefox.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

in opzioni/generale/lingua, inserisco 4 o 5 lingue alternative, sia nel menu che nella visualizzazione delle pagine

in the options/general/language, I insert 4 or 5 alternative languages, both in the menu and in the visualization of the pages

Actual results:

se provo a inserirw una nuova ulteriore lingua scompaiono i tasti ok in basso della finestre non posso confermare

if I try to insert a new language the ok keys at the bottom of the window disappears and I can not confirm

Comment 1

[Francesco Lodolo [:flod]]

It looks like the window keeps growing taller. Note that you can resize the window (drag the bottom right corner), but the behavior seems wrong, it should display a scrollbar at some point, instead of making the buttons disappear.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:jaws, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 9

[Francesco Lodolo [:flod]]

Carrying over priority/severity from bug 1652195, hoping that's acceptable.

We had 2 bugs on file for the same issue (and a few dupes for each).

Comment 11

[Itiel]

I think this should be a matter of just hardcoding a certain height to the richlistbox, say max-height: calc(<number-of-visible-richlistitems> * (1.8em + 0.6em + 2px)), or something.
(line-height + padding-top&bottom + borders)

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1644612 - Add a height and cleanup languages listbox styling. r=mconley,Gijs

The "righter" way to do this is adding a bunch of min-height: 0 to the
grid, the dialog, the content box, etc. But this is more similar to what
other dialogs do.

Comment 14

[:Gijs (he/him)]

It would be nice to get this fixed... Emilio, do you have time to investigate a solution that addresses Dão's comments?

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Updated

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8d6bde5d9d8
Add a height and cleanup languages listbox styling. r=desktop-theme-reviewers,dao

Comment 17

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d8d6bde5d9d8

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Worth Beta and ESR115 uplift nominations given the number of dupes?

Comment 19

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1644612 - Add a height and cleanup languages listbox styling. r=mconley,Gijs

The "righter" way to do this is adding a bunch of min-height: 0 to the
grid, the dialog, the content box, etc. But this is more similar to what
other dialogs do.

Original Revision: https://phabricator.services.mozilla.com/D180890

Comment 20

[Phabricator Automation]

Uplift Approval Request

• Explanation of risk level: well scoped CSS change
• Risk associated with taking this patch: low
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: comment 0
• Is Android affected?: no
• String changes made/needed: none
• User impact if declined: comment 0
• Code covered by automated testing: no

Comment 21

[Dianna Smith [:diannaS]]

Comment on attachment 9361166 [details]
Bug 1644612 - Add a height and cleanup languages listbox styling. r=mconley,Gijs

Approved for 120.0b5

Comment 22

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a6dedbe86cd7

Comment 23

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly from 2023-10-22, verified that the buttons are not hidden when more languages are added into the menu using latest Nightly 121.0a1 and latest Firefox 120.0b5 build across platforms (Windows 10, macOS 13 and Ubuntu 22.04). Leaving the bug as resolved fixed until this is fixed on esr115 as well.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9361166 [details]
Bug 1644612 - Add a height and cleanup languages listbox styling. r=mconley,Gijs

Approved for 115.5esr

Comment 25

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/d87c7891b0c7

Comment 26

[Bogdan Maris, Desktop Test Engineering]

Also verified fixed on esr115 using the latest build from treeherder across platforms (Windows 10, macOS 13 and Ubuntu 22.04).