1646168 - clang-plugin test failures with clang 11

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect, P3)

Description

[(Away)]

With clang trunk eae76faeeae7110389047c9d1ebe90990dec3497, several tests are not producing the expected errors. I've fixed some of the trivial syntactic issues in bug 1646158 but the following files have less-obvious problems that need a deeper investigation.

'TestCanRunScript.cpp',
'TestHeapClass.cpp',
'TestNANTestingExpr.cpp',
'TestNoArithmeticExprInArgument.cpp',
'TestNonTemporaryClass.cpp',
'TestRefCountedCopyConstructor.cpp',
'TestTemporaryClass.cpp',

Andi, would you be able to take a look?

Comment 1

[(Away)]

Here's another issue, the escapesFunction checker seems to be producing false positives:

modules/libpref/Preferences.cpp(1794,61): error: escapes function error: expression is not in call
       console->LogStringMessage(NS_ConvertUTF8toUTF16(aMsg).get());
                                                             ^

Comment 2

[Andi [:andi]]

I've used trunk cff57391575da6bcc6f31e196bd73fa928b3abcb and I cannot reproduced the described issue, only some minor issues in the tests files that are easily fixable like you said.
Can you please try again?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[(Away)]

Attachment: Allow optional arrows in TestCanRunScript.cpp errors

These started appearing in clang 11.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ec638a14304
Allow optional arrows in TestCanRunScript.cpp errors r=andi

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3ec638a14304