1646535 - Figure out if GetInProcessScriptableTop usage in nsPIDOMWindowOuter::SetServiceWorkersTestingEnabled is OK

Status: RESOLVED DUPLICATE of bug 1655967

(DevTools :: General, task)

Description

[Kris Maglione [:kmag]]

Under Fission, the assertion MOZ_ASSERT_IF(aEnabled, this == GetInProcessScriptableTop()) allows turning on service worker testing in frames with an out-of-process parent, which may or may not be desired. Either way, a comment should be added to clarify what's expected.

Comment 1

[Kris Maglione [:kmag]]

(Similar issue for GetServiceWorkersTestingEnabled)

Comment 2

[Chris Peterson [:cpeterson]]

Tracking "Figure out GetInProcessTop usage" bugs for Fission M6b.

Comment 3

[Neha Kochar [:neha]]

The comment in the code says
void nsPIDOMWindowOuter::SetServiceWorkersTestingEnabled(bool aEnabled) {
// Devtools should only be setting this on the top level window. Its
// ok if devtools clears the flag on clean up of nested windows, though.
// It will have no affect.

Alex, can you review the urgency of fixing this for Fission?

Comment 4

[Alexandre Poirot [:ochameau]]

DevTools should toggle this setting only on top level windows.
So that this assertion doesn't sound super important to keep, we are conscious that it may be wrong trying to toggle this in a nested remote iframe.

Having said that, this attribute should probably be moved to BrowsingContext, like watchedByDevTools (bug 1620966).
But again, it rather sounds like a useful esthetical cleanup rather than a real requirement.

Comment 5

[Alexandre Poirot [:ochameau]]

About moving this attribute to BrowsingContext, I opened bug 1655967 about this.

Comment 6

[Chris Peterson [:cpeterson]]

Adding dt-fission whiteboard tag to DevTools bugs that mention Fission or block Fission meta bugs but don't already have a dt-fission whiteboard tag.

Comment 7

[Chris Peterson [:cpeterson]]

Moving dt-fission bugs to Fission MVP.

Comment 8

[Neha Kochar [:neha]]

Bulk change of all bugs with whiteboard tag of dt-fission to Fission MVP milestone.

Comment 9

[Chris Peterson [:cpeterson]]

Moving old "dt-fission" bugs to "dt-fission-future" because they don't block Fission MVP.

Comment 10

[Chris Peterson [:cpeterson]]

Resolving as a dupe of bug 1655967, which moved SetServiceWorkersTestingEnabled from nsPIDOMWindowOuter to BrowsingContext.