1655967 - Move nsIWindowUtils::serviceWorkersTestingEnabled to BrowsingContext

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

+++ This bug was initially created as a clone of Bug #1655959 +++

This attribute is used by DevTools and is expected to be also applied to remoted Fission iframe.
By setting this attribute on nsIWindowUtils, we don't ensure applying it to remote iframe, which spawn another nsIWindowUtils in their distinct process.
The typical way to fix that is to move such attribute up to BrowsingContext class.
You can take example on bug 1593708, which moved inRDMPanel from PresShell up to BrowsingContext. Or bug 1620966, which moved watchedByDevTools from DocShell up to BrowsingContext.

I imagine that it may also fix non-devtools usecase if this attribute is toggled outside of DevTools.
See bug 1591120 for extensive context.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-reserve bugs for Fission Beta milestone (M7).

Comment 2

[Hiroyuki Ikezoe (:hiro)]

This one doesn't look propagating the flag into descendant documents either.

I am not familiar with this stuff at all, :ochameau can you please do double-check it?

Comment 3

[Alexandre Poirot [:ochameau]]

Yes, the current implementation doesn't seem to apply to descendant documents.

But I think that's an issue. When a user toggles this via DevTools, he could easily expect this to affect iframes.
We are also trying to unify the implementation and behavior of all similar attributes DevTools are using. Many are meant to be set on the BrowsingContext.

Otherwise, if you think this bug would be better triaged in another component, I'm fine moving it to DevTools.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Yes, I think this should be in one of Devtools components.

Comment 5

[Neha Kochar [:neha]]

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Comment 6

[Chris Peterson [:cpeterson]]

Moving "dt-fission-m3-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

This doesn't seem to be propagated to in-process iframes today, what am I missing?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Ah, service workers test this on the top window. I see.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1655967 - Clean up touch events override code. r=nika

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1655967 - Move serviceWorkersTestingEnabled to BrowsingContext. r=nika

Depends on D103756

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e224f019253
Move serviceWorkersTestingEnabled to BrowsingContext. r=nika

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/badc370173e6
Fix ESLint.

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8e224f019253
https://hg.mozilla.org/mozilla-central/rev/badc370173e6

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d75c5b046bd2
Clean up touch events override code. r=farre

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d75c5b046bd2