Closed Bug 1655967 Opened 2 years ago Closed 2 years ago

Move nsIWindowUtils::serviceWorkersTestingEnabled to BrowsingContext

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(Fission Milestone:Future, firefox87 fixed)

RESOLVED FIXED
87 Branch
Fission Milestone Future
Tracking Status
firefox87 --- fixed

People

(Reporter: ochameau, Assigned: emilio)

References

Details

(Whiteboard: dt-fission-future)

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1655959 +++

This attribute is used by DevTools and is expected to be also applied to remoted Fission iframe.
By setting this attribute on nsIWindowUtils, we don't ensure applying it to remote iframe, which spawn another nsIWindowUtils in their distinct process.
The typical way to fix that is to move such attribute up to BrowsingContext class.
You can take example on bug 1593708, which moved inRDMPanel from PresShell up to BrowsingContext. Or bug 1620966, which moved watchedByDevTools from DocShell up to BrowsingContext.

I imagine that it may also fix non-devtools usecase if this attribute is toggled outside of DevTools.
See bug 1591120 for extensive context.

Component: Layout → DOM: Service Workers

Tracking dt-fission-m2-reserve bugs for Fission Beta milestone (M7).

Fission Milestone: --- → M7

This one doesn't look propagating the flag into descendant documents either.

I am not familiar with this stuff at all, :ochameau can you please do double-check it?

Flags: needinfo?(poirot.alex)

Yes, the current implementation doesn't seem to apply to descendant documents.

But I think that's an issue. When a user toggles this via DevTools, he could easily expect this to affect iframes.
We are also trying to unify the implementation and behavior of all similar attributes DevTools are using. Many are meant to be set on the BrowsingContext.

Otherwise, if you think this bug would be better triaged in another component, I'm fine moving it to DevTools.

Flags: needinfo?(poirot.alex)

Yes, I think this should be in one of Devtools components.

Component: DOM: Service Workers → General
Product: Core → DevTools

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Fission Milestone: M7 → MVP
Severity: -- → S3
Priority: -- → P3
Whiteboard: dt-fission-m2-reserve → dt-fission-m2-reserve, dt-fission-m3-mvp
Whiteboard: dt-fission-m2-reserve, dt-fission-m3-mvp → dt-fission-m3-mvp
Whiteboard: dt-fission-m3-mvp → dt-fission-m3-reserve

Moving "dt-fission-m3-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Fission Milestone: MVP → Future
Whiteboard: dt-fission-m3-reserve → dt-fission-future

This doesn't seem to be propagated to in-process iframes today, what am I missing?

Flags: needinfo?(poirot.alex)

Ah, service workers test this on the top window. I see.

Flags: needinfo?(poirot.alex)
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e224f019253
Move serviceWorkersTestingEnabled to BrowsingContext. r=nika
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d75c5b046bd2
Clean up touch events override code. r=farre
No longer blocks: 1716964
You need to log in before you can comment on or make changes to this bug.