Closed Bug 1685424 Opened 11 months ago Closed 8 months ago

Re-enable toolkit/components/extensions/test/mochitest/test_ext_contentscript_activeTab.html test for Fission

Categories

(WebExtensions :: General, task, P2)

task

Tracking

(Fission Milestone:M7a, firefox-esr78 disabled, firefox86 disabled, firefox87 disabled, firefox88 disabled, firefox89 fixed)

RESOLVED FIXED
89 Branch
Fission Milestone M7a
Tracking Status
firefox-esr78 --- disabled
firefox86 --- disabled
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- fixed

People

(Reporter: cpeterson, Assigned: zombie)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Tom, is this test still failing with Fission? Does fixing and re-enabling this test need to block shipping Fission MVP?

This toolkit/components/extensions/test/mochitest/test_ext_contentscript_activeTab.html test is currently skipped for Fission (by bug 1646573):

[test_ext_contentscript_activeTab.html]
skip-if = os == 'android' || fission

https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/toolkit/components/extensions/test/mochitest/mochitest-common.ini#94-95

Flags: needinfo?(tomica)

Yes, this functionality (not the test) should probably block MVP.

Looking into.

Assignee: nobody → tomica
Severity: -- → N/A
Flags: needinfo?(tomica)
Priority: -- → P2

zombie recommends that this test bug still block Fission M7.

Depends on: 1698398
Depends on: 1581859

The webNavigation.getAllFrames functionality needed for this test is being fixed in bug 1698398.

Additionally, this also depends webNavigation.onCompleted event on iframes, which is being fixed in bug 1581859.

Fission Milestone: M7 → M7a
Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50aeb68f1f5a
Enable test_ext_contentscript_activeTab test with fission r=robwu
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.