1646958 - The text on the Global Sharing Overlay (when sharing screen) is not displayed correctly when in high contrast on Windows/dark theme on Linux

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P1)

Description

[Daniel Bodea [:danibodea]]

Attachment: the text is not visible with high contrast theme.png

Note

• When the user activates high contrast and shares his screen in a conference, he will notice that the text on the Global Sharing Overlay is not being displayed.

Affected versions

• Nightly v79.0a1
• Beta v78.0b9 shows this behavior: bug 1643012

Affected platforms

• Windows 10
• Windows 7

Steps to reproduce

1. Make sure prefs
   privacy.webrtc.allowSilencingNotifications = true
   privacy.webrtc.legacyGlobalIndicator = false
2. Apply a high contrast theme from OS settings.
3. Engage in a video conference on ant WebRTC web-app.
4. Share a screen or a window.
5. Observe the Global Sharing Overlay.

Expected result

• The Global Sharing Overlay is correctly displayed.

Actual result

• The text displayed on the Global Sharing Overlay is improperly displayed.

Regression range

• This is an issue with the newly implemented design seen in Nightly v79.0a1.

Additional notes

• The text will be displayed on yellow, green or not visible at all, based on the High Contrast theme applied.

Comment 1

[Daniel Bodea [:danibodea]]

The exact same issue occurs when setting a dark theme on Ubuntu in Nightly v79.0a1 (the "You are sharing..." text is improperly displayed). Should I log a separate bug?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Test message for the stream.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Here's the answer, welcome to the bug, 12345

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: High contrast mode on Windows 7

My current patch (which I'll post shortly) renders the indicator like the screenshot in high contrast mode now.

Thanks to Youri Wims who helped put this together with me.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1646958 - Fix styling for WebRTC indicator when in High Contrast mode on Windows, or the user is using a dark theme. r?ntim!

Thanks to Youri Wims for helping me put this patch together.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1646958 - Allow windows without sidebars to use LightweightThemeConsumer. r?ntim!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49c8ba00b68b
Fix styling for WebRTC indicator when in High Contrast mode on Windows, or the user is using a dark theme. r=ntim

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/49c8ba00b68b

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[Daniel Bodea [:danibodea]]

The Global Sharing Overlay now properly displays all the buttons and texts. The "Stop Sharing" button may change its shape depending on whether the text is displayed on 2 rows or not, however, the functionality of the Global Sharing Overlay remains intact.

I deem this bug verified. Tested on Windows 10, Windows 7 and Ubuntu 20 (dark theme), on Nightly v80.0a1 from 2020-07-14.