1647256 - Search cache isn't saving the built-in engine list, errors raised when upgrading from old version.

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Mark Banner (:standard8)]

This is fixing a couple of issues that I've picked up on whilst working on the latest code:

• We're not writing cache.builtInEngineList properly since the move to a separate SearchCache object (bug 1632471).
• When upgrading from older versions, we get lots of errors about failing to load engines because json._urls is undefined. These are because we don't recongnise them as app-provided engines as they're using the old isBuiltIn flag (bug 1631898)

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1647256 - Correctly save the current engine list to the cache when modern configuration is on. r?daleharvey!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1647256 - When loading search engines, use the old _isBuiltin flag as well as the _isAppProvided one to prevent errors. r?daleharvey!

The added test provides extra coverage for loading the legacy version of the cache file. It does not cover the exact errors as we don't have coverage to catch those at the moment.

Depends on D80454

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca4dbd522647
Correctly save the current engine list to the cache when modern configuration is on. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/06cbf21e903c
When loading search engines, use the old _isBuiltin flag as well as the _isAppProvided one to prevent errors. r=daleharvey

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ca4dbd522647
https://hg.mozilla.org/mozilla-central/rev/06cbf21e903c