1631898 - Handle normandy installed search addons in SearchService startup

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Dale Harvey (:daleharvey)]

As the last part to https://bugzilla.mozilla.org/show_bug.cgi?id=1625179

SearchService assumes all addons referenced by the configurations are going to be builtIn and installed via |AddonManager.installBuiltinAddon(path)|, if an updated addon is being delivered via normandy then that is not going to work

For active addons that report to the SearchService on startup we should probably be able to do a lookup from the engines the AddonManager has reported to us. However if an addon has not yet been installed but has been updated I am not sure how that will work

Comment 1

[Dale Harvey (:daleharvey)]

Hey Shane, I am not 100% certain we havent already covered this and I have forgotten, if so sorry, but just in case there is work we need to do here

I am thinking about the case:

1. Boot firefox in USA, SearchService installs google, amazon, twitter
2. We update the the codes for Yandex, deliver an updated extension via Normandy
3. We go to Russia, Firefox has figured out we have moved region, loads new engines including Yandex

How does SearchService ensure Yandex is installed?

Cheers

Comment 2

[Mark Banner (:standard8)]

(In reply to Dale Harvey (:daleharvey) from comment #1)

I am thinking about the case:

1. Boot firefox in USA, SearchService installs google, amazon, twitter
2. We update the the codes for Yandex, deliver an updated extension via Normandy
3. We go to Russia, Firefox has figured out we have moved region, loads new engines including Yandex

How does SearchService ensure Yandex is installed?

My expectations are that the updated extension would only be delivered to the relevant regions. If Firefox switches regions to Russia, it will load Yandex and other engines via the search engine config, so will probably get the built-in versions. Once Remote Settings kicks in, then we'll get the updated Yandex delivered to us, at which point add-on manager will notify the search service to update.

Comment 3

[Dale Harvey (:daleharvey)]

That is possible, but it will always be possible (and very likely until we consolidate region fetching) that normandy delivers the update before the SearchService sees the new region so it would be good to know what happens when we AddonManager.installBuiltInAddon an addon that has a normandy delivered update.

Comment 4

[Dale Harvey (:daleharvey)]

So discussed this with Shane last night, as it stands normandy installed addons will be treated by the SearchService as user installed engines. We need to add checks for isSystem to the current places that we currently check for isBuiltIn, with that normandy addons should just work as we expect, although we "may" want to do some refactoring of the startup path @ https://searchfox.org/mozilla-central/source/toolkit/components/search/SearchService.jsm#2559 at the same time

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: Bug 1631898 - Handle Normandy installed system search extensions.

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: Bug 1631898 - Handle Normandy installed system search extensions.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e61cb1a6d0f
Handle Normandy installed system search extensions. r=Standard8

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9e61cb1a6d0f