1647727 - Dropdown menu on Add-on Manager wont show up

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dn Sc]

Attachment: 2020-06-23 11-07-59.2020-06-23 11_10_07.gif

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

In a add-on with dropdown menu inside your own preferences on Add-on manager click to choose a option. But the list don't show up.

Add-on tested "Tumblr Post" (https://addons.mozilla.org/en-US/firefox/addon/tumblr-post/) and "Minimal Twitter" (https://addons.mozilla.org/en-US/firefox/addon/min-twitter/)

Issue found in Nightly 79 and Dev 78. FF 77 still works well.

Actual results:

The dropdown list don't show up.

Expected results:

Access the list.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]: GUI of add-ons option is broken

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cc8881b3128c07537ad0c9c0a0dd35b0d9ce8a99&tochange=8604456ea61eafc35ae28670d95e8595ee850f6e

Comment 2

[Alice0775 White]

When I click the select element, Browser console shows the following an error:
TypeError: can't access property "getZoomForBrowser", window.ZoomManager is undefined SelectParent.jsm:737:20

Comment 3

[Julien Cristau [:jcristau]]

Can you double check the status on 78? Bug 1643522 was uplifted there, and comment 0 says it's also affected.

Comment 4

[Alice0775 White]

(In reply to Julien Cristau [:jcristau] from comment #3)

Can you double check the status on 78? Bug 1643522 was uplifted there, and comment 0 says it's also affected.

oops, yes my bad.
This bug is reproduced on Firefox78.0rc(20200622230509).

Comment 5

[Alice0775 White]

[Tracking Requested - why for this release]:GUI of add-ons option is broken

Comment 6

[:Gijs (he/him)]

Attachment: Bug 1647727 - make SelectParent find ZoomManager on the top window (fix dropdowns in add-on manager), r?emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/298c0914b5af
make SelectParent find ZoomManager on the top window (fix dropdowns in add-on manager), r=emilio

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1647727 - beta patch - make SelectParent find ZoomManager on the top window (fix dropdowns in add-on manager), r?emilio

Comment 9

[:Gijs (he/him)]

Comment on attachment 9158846 [details]
Bug 1647727 - beta patch - make SelectParent find ZoomManager on the top window (fix dropdowns in add-on manager), r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: broken add-on configuration UI
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment #0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a fairly straightforward JS patch, that shouldn't affect functionality in "normal" tabs at all, only cases where we currently don't get a zoom manager. It's a slightly more tedious version of the nightly one, because https://bugzilla.mozilla.org/show_bug.cgi?id=1638153 didn't make 78 so the convenient topChromeWindow getter doesn't exist. Backing out the regressor would break zoom in select dropdowns in way more other places, so that seems like a worse trade-off.
• String changes made/needed: nope

Comment 10

[:Gijs (he/him)]

Comment on attachment 9158846 [details]
Bug 1647727 - beta patch - make SelectParent find ZoomManager on the top window (fix dropdowns in add-on manager), r?emilio

Bah, should have asked for release uplift, see previous comment.

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/298c0914b5af

Comment 12

[Anca Soncutean, Desktop QA]

I've reproduced this issue with Fx 79.0a1 (2020-06-22) on Windows 10.
I can confirm the fix with Fx 79.0a1 (2020-06-25) on Windows 10 and Ubuntu 18.04.

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9158846 [details]
Bug 1647727 - beta patch - make SelectParent find ZoomManager on the top window (fix dropdowns in add-on manager), r?emilio

approved for 78 rc2

Comment 14

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/9ec0743afec6

Comment 15

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/9ec0743afec6

Comment 16

[Anca Soncutean, Desktop QA]

Issue verified fixed with 78.0 RC (build2) and 78.0 ESR (build3) across platforms (Windows 10, macOS 10.15 and Ubuntu 18.04).