1647851 - Printing changes to support @page rule size attribute

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P2)

Description

[Emily McDonough [:alaskanemily]]

• Adding querying ability to the printers (even if it's just dummied out), see bug 1646829
• "Negotiation" code to find the ideal paper size. We could begin with this just choosing to split up oversize and center undersize images on the default/chosen paper size.
• Page size information could be stored on the nsPrintData.

I'm still unsure of the following aspects:

• How will we need to handle media queries on the page-rules? Does this already work?
• What do we do about the RenderContext? How does it handle changing paper size from print preview currently?

Comment 1

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1647851 Part 1 - Use a computed type for page-size which converts paper sizes to a Size2D.

Comment 2

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1647851 Part 2 - Apply CSS page-size when printing

This isn't finished. Headers and footers do not correctly align to either the
full sheet or the scaled/cropped page.

Comment 3

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1647851 Part 3 - Add basic tests for applying page-size when printing

These aren't WPT because the CSS-page spec gives a large range of correct
behavior for handling page-size when printing. We also don't expect Firefox's
default handling to remain the same as it is implemented in this bug.

Ideally we would be able to give a range of possible correct results for a WPT
that tests printing, but for now we are just testing the specific behavior we
implement.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af6772261f2b
Part 1 - Use a computed type for page-size which converts paper sizes to a Size2D. r=emilio
https://hg.mozilla.org/integration/autoland/rev/1c18b7c90eb8
Part 2 - Apply CSS page-size when printing r=emilio
https://hg.mozilla.org/integration/autoland/rev/4aee63294f39
Part 3 - Add basic tests for applying page-size when printing r=dholbert

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/af6772261f2b
https://hg.mozilla.org/mozilla-central/rev/1c18b7c90eb8
https://hg.mozilla.org/mozilla-central/rev/4aee63294f39