1648358 - No sharing indicator is displayed when alerts.useSystemBackend is enabled

Status: RESOLVED FIXED

(Firefox :: Site Permissions, defect, P3)

Description

[[:philipp]]

at least under windows where i could test the issue, the new sharing indicator is not getting displayed when alerts.useSystemBackend is enabled (which is a non-default value), and there is no indication in the address bar that camera/mic/screen-sharing is taking place in firefox either.

Comment 1

[Paul Zühlcke [:pbz]]

This seems to be a regression of Bug 1635257.

Setting the suppress notification flag fails here: https://searchfox.org/mozilla-central/rev/a87a1c3b543475276e6d57a7a80cb02f3e42b6ed/browser/modules/webrtcUI.jsm#451
NS_ERROR_NOT_IMPLEMENTED: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIAlertsDoNotDisturb.suppressForScreenSharing]

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1648358 - Modernize a bit ToastNotification. r=saschanaz

Nobody is using the weak reference stuff so remove it.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1648358 - Implement nsIAlertDoNotDisturb for windows native alerts. r=saschanaz

This happens to be D76407, but I missed it before writing this.

Depends on D139360

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bfe789a1934
Modernize a bit ToastNotification. r=saschanaz
https://hg.mozilla.org/integration/autoland/rev/3edd136f27f6
Implement nsIAlertDoNotDisturb for windows native alerts. r=saschanaz

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0bfe789a1934
https://hg.mozilla.org/mozilla-central/rev/3edd136f27f6