1648686 - (mac) pan/pinch events rollup menus that we don't want to rollup

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Timothy Nikkel (:tnikkel)]

Basically the same bug as bug 1647546 except on mac and only affects pinch gestures.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1634855

Comment 2

[Timothy Nikkel (:tnikkel)]

Actually 78 is affected because all it takes is a pinch gesture on the trackpad to trigger this (no need to turn on desktop zooming or anything).

Comment 3

[Rachel Tublitz [:rachel]]

Hi, would you mind setting a severity for this one?

Comment 4

[Botond Ballo [:botond]]

Setting S3 as pinch gestures are not likely to be very common without desktop zooming enabled.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

I can take this one too.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1648686 - Don't rollup the hamburger menu when pinching over content (on mac). r?tnikkel

It seems like ShouldRollupOnMouseWheelEvent really means something more like
"ShouldRollupIfPageIsGonnaMove" so it seems appropriate to use in this
situation. Might be worth renaming the function at some point if my interpration
is correct, but the name propagates into xhtml attributes and such so it's
more than I want to do right now.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ef828c9bd89
Don't rollup the hamburger menu when pinching over content (on mac). r=tnikkel

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9ef828c9bd89