1648868 - Setup a tab modal overlay for print preview UI

Status: RESOLVED FIXED

(Toolkit :: Printing, enhancement, P1)

Description

[Mark Striemer [:mstriemer]]

With the reusable tab modal overlay we should be able to load the print preview UI inside of it.

Comment 1

[Mark Striemer [:mstriemer]]

Since we're targetting 81 now this can move forward using SubDialog for now and later migrate to to TabDialogBox (bug 1650795) when that's ready.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1648868 - Part 2: Move modal print UI into a tab modal r?pbz

This gets the print UI into a tab modal but does so by abusing
SubDialog. This should be migrated to TabDialogBox in bug 1653317.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f8b675f0f6b
Move modal print UI into a tab modal r=Gijs

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1653392, Bug 1648868) for causing failures in browser_modal_print.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=7fac5bd02bb3c962c2b68ea682877772ddd98268&selectedTaskRun=amW8Zz1tTmePWqWzF7LnIg.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310984986&repo=autoland&lineNumber=4726

Backout: https://hg.mozilla.org/integration/autoland/rev/4a5520ecb0752ea1264c0c580964b995cda4e191

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1648868 - Part 1: Cleanup SubDialog for tab-level usage r?pbz!,emalysz

Refactor how listeners are added to ensure that all listeners that have
been added are cleaned up properly.
Add some extra options for where to add the overlay, template support,
cleanup on close and a promise for when the dialog is set up.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa8732ebff70
Part 1: Cleanup SubDialog for tab-level usage r=emalysz
https://hg.mozilla.org/integration/autoland/rev/5c984392950a
Part 2: Move modal print UI into a tab modal r=Gijs

Comment 7

[Andreea Pavel [:apavel]]

Backed out for failing bc at /browser_modal_print.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=e6f8429bae890d2399a40559d239487768d95cbe&selectedTaskRun=UiZ0USa0R8aTXiggri0D6w.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311705425&repo=autoland&lineNumber=15831

Backout: https://hg.mozilla.org/integration/autoland/rev/b36594479be22d5240e7c6bfc3e1cebf206d7011

***keep in mind, all bugs from that push got backed out.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7f8623105f9
Part 1: Cleanup SubDialog for tab-level usage r=emalysz
https://hg.mozilla.org/integration/autoland/rev/a09b54a535f4
Part 2: Move modal print UI into a tab modal r=Gijs

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d7f8623105f9
https://hg.mozilla.org/mozilla-central/rev/a09b54a535f4