Closed Bug 1648868 Opened 3 months ago Closed 2 months ago

Setup a tab modal overlay for print preview UI

Categories

(Toolkit :: Printing, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: mstriemer, Assigned: mstriemer, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [print2020_v81])

Attachments

(2 files)

With the reusable tab modal overlay we should be able to load the print preview UI inside of it.

See Also: → 1650795
Whiteboard: [print2020_v80]

Since we're targetting 81 now this can move forward using SubDialog for now and later migrate to to TabDialogBox (bug 1650795) when that's ready.

Depends on: 1652627, 133787
No longer depends on: 1648867
Blocks: 133787, 1652627
No longer depends on: 133787, 1652627
No longer blocks: 1652627
Depends on: 1652627
Blocks: 1653392
Whiteboard: [print2020_v80] → [print2020_v81]
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED

This gets the print UI into a tab modal but does so by abusing
SubDialog. This should be migrated to TabDialogBox in bug 1653317.

See Also: → 1654962
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f8b675f0f6b
Move modal print UI into a tab modal r=Gijs

Refactor how listeners are added to ensure that all listeners that have
been added are cleaned up properly.
Add some extra options for where to add the overlay, template support,
cleanup on close and a promise for when the dialog is set up.

Attachment #9164867 - Attachment description: Bug 1648868 - Move modal print UI into a tab modal r?Gijs,pbz → Bug 1648868 - Part 2: Move modal print UI into a tab modal r?pbz
Attachment #9166865 - Attachment description: Bug 1648868 - Part 1: Refactor SubDialog for tab-level usage r?pbz! → Bug 1648868 - Part 1: Cleanup SubDialog for tab-level usage r?pbz!,emalysz
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa8732ebff70
Part 1: Cleanup SubDialog for tab-level usage r=emalysz
https://hg.mozilla.org/integration/autoland/rev/5c984392950a
Part 2: Move modal print UI into a tab modal r=Gijs
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7f8623105f9
Part 1: Cleanup SubDialog for tab-level usage r=emalysz
https://hg.mozilla.org/integration/autoland/rev/a09b54a535f4
Part 2: Move modal print UI into a tab modal r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Severity: -- → N/A
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.