1654962 - Resize print modal as the browser size changes

Status: VERIFIED FIXED

(Toolkit :: Printing, enhancement, P1)

Description

[Mark Striemer [:mstriemer]]

The size of the modal print UI is currently a fixed width and height. It should gracefully scale based on the size of the window.

Comment 1

[Mark Striemer [:mstriemer]]

At the current preview size with one page to print there is currently a scrollbar on the preview. If we have an expected preview size then we should make it fit a full single page preview without scrolling. See attachment 9167767 [details] from bug 1657010

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1654962 - Size tab modal print UI to available window size r?pbz!,gijs!

Comment 5

[Mark Striemer [:mstriemer]]

Note that when the sidebar is open our available space is constrained (bug 1658138).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80e6be24260d
Size tab modal print UI to available window size r=Gijs,sfoster,emalysz,pbz

Comment 7

[Alexandru Michis [:malexandru]]

Backed out changeset 80e6be24260d (Bug 1654962) for causing bc failures in browser_modal_print.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f083244c4833d92ff047d23ce6184b3fec72d6f6

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=80e6be24260d34c7638715107e676806817d0a43&selectedTaskRun=M6MlaolCRiuxWmIGZrC9wA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313662595&repo=autoland&lineNumber=7220
Also seeing failures in browser_bug436200.js:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313662355&repo=autoland&lineNumber=5336

(Update) Failures in test_modal_prompts.html:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313663712&repo=autoland&lineNumber=124449

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72ba4a955fb4
Size tab modal print UI to available window size r=Gijs,sfoster,emalysz,pbz

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/72ba4a955fb4

Comment 10

[Jonathan Watt [:jwatt]]

Reminder to request beta uplift.

Comment 11

[Mark Striemer [:mstriemer]]

Comment on attachment 9168202 [details]
Bug 1654962 - Size tab modal print UI to available window size r?pbz!,gijs!

Beta/Release Uplift Approval Request

• User impact if declined: Print dialog is always small, could be too small on a large window or have hidden elements on a small one.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Changes are only to the new print UI, which is behind a pref. Has tests.
• String changes made/needed: No

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9168202 [details]
Bug 1654962 - Size tab modal print UI to available window size r?pbz!,gijs!

Approved for 81.0b2.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ca6a0aa9a54d

Comment 14

[Anca Soncutean, Desktop QA]

Verified fixed with Fx 82.0a1 (2020-09-02) and Fx 81.0b5 with Windows 10, macOS 10.14 and Ubuntu 18.04.