Closed Bug 1654962 Opened 1 year ago Closed 1 year ago

Resize print modal as the browser size changes

Categories

(Toolkit :: Printing, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
82 Branch
Tracking Status
firefox81 --- verified
firefox82 --- verified

People

(Reporter: mstriemer, Assigned: mstriemer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [print2020_v81])

Attachments

(1 file)

The size of the modal print UI is currently a fixed width and height. It should gracefully scale based on the size of the window.

At the current preview size with one page to print there is currently a scrollbar on the preview. If we have an expected preview size then we should make it fit a full single page preview without scrolling. See attachment 9167767 [details] from bug 1657010

Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Duplicate of this bug: 1657953
Duplicate of this bug: 1658405

Note that when the sidebar is open our available space is constrained (bug 1658138).

Attachment #9168202 - Attachment description: Bug 1654962 - Resize tab modal print UI based on window size → Bug 1654962 - Size tab modal print UI to avialable window size r?pbz!,gijs!
Blocks: 1659767
Attachment #9168202 - Attachment description: Bug 1654962 - Size tab modal print UI to avialable window size r?pbz!,gijs! → Bug 1654962 - Size tab modal print UI to available window size r?pbz!,gijs!
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80e6be24260d
Size tab modal print UI to available window size r=Gijs,sfoster,emalysz,pbz
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72ba4a955fb4
Size tab modal print UI to available window size r=Gijs,sfoster,emalysz,pbz
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Flags: needinfo?(mstriemer)

Reminder to request beta uplift.

Flags: needinfo?(mstriemer)

Comment on attachment 9168202 [details]
Bug 1654962 - Size tab modal print UI to available window size r?pbz!,gijs!

Beta/Release Uplift Approval Request

  • User impact if declined: Print dialog is always small, could be too small on a large window or have hidden elements on a small one.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Changes are only to the new print UI, which is behind a pref. Has tests.
  • String changes made/needed: No
Flags: needinfo?(mstriemer)
Attachment #9168202 - Flags: approval-mozilla-beta?

Comment on attachment 9168202 [details]
Bug 1654962 - Size tab modal print UI to available window size r?pbz!,gijs!

Approved for 81.0b2.

Attachment #9168202 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified fixed with Fx 82.0a1 (2020-09-02) and Fx 81.0b5 with Windows 10, macOS 10.14 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.