Resize print modal as the browser size changes
Categories
(Toolkit :: Printing, enhancement, P1)
Tracking
()
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
(Whiteboard: [print2020_v81])
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
The size of the modal print UI is currently a fixed width and height. It should gracefully scale based on the size of the window.
Assignee | ||
Comment 1•3 years ago
|
||
At the current preview size with one page to print there is currently a scrollbar on the preview. If we have an expected preview size then we should make it fit a full single page preview without scrolling. See attachment 9167767 [details] from bug 1657010
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 5•3 years ago
|
||
Note that when the sidebar is open our available space is constrained (bug 1658138).
Updated•3 years ago
|
Updated•3 years ago
|
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/80e6be24260d Size tab modal print UI to available window size r=Gijs,sfoster,emalysz,pbz
Comment 7•3 years ago
•
|
||
Backed out changeset 80e6be24260d (Bug 1654962) for causing bc failures in browser_modal_print.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/f083244c4833d92ff047d23ce6184b3fec72d6f6
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313662595&repo=autoland&lineNumber=7220
Also seeing failures in browser_bug436200.js:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313662355&repo=autoland&lineNumber=5336
(Update) Failures in test_modal_prompts.html:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313663712&repo=autoland&lineNumber=124449
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/72ba4a955fb4 Size tab modal print UI to available window size r=Gijs,sfoster,emalysz,pbz
Comment 9•3 years ago
|
||
bugherder |
![]() |
||
Updated•3 years ago
|
Assignee | ||
Comment 11•3 years ago
|
||
Comment on attachment 9168202 [details]
Bug 1654962 - Size tab modal print UI to available window size r?pbz!,gijs!
Beta/Release Uplift Approval Request
- User impact if declined: Print dialog is always small, could be too small on a large window or have hidden elements on a small one.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Changes are only to the new print UI, which is behind a pref. Has tests.
- String changes made/needed: No
Comment 12•3 years ago
|
||
Comment on attachment 9168202 [details]
Bug 1654962 - Size tab modal print UI to available window size r?pbz!,gijs!
Approved for 81.0b2.
Comment 13•3 years ago
|
||
bugherder uplift |
Comment 14•3 years ago
|
||
Verified fixed with Fx 82.0a1 (2020-09-02) and Fx 81.0b5 with Windows 10, macOS 10.14 and Ubuntu 18.04.
Description
•