1649423 - OAuth window missing URL bar

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Magnus Melin [:mkmelin]]

Bug 1644083 changed the browserrequest window to hide the "urlbar" for extenstion popups. That's ok, but it shouldn't have changed the window used for OAuth.

The URL bar is needed for OAuth for debugging and also e.g. Google imply it's required to show it.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1649423_oauth_urlbar_missing.patch

Comment 2

[Geoff Lankow (:darktrojan)]

I think we should go the other way and specify "location" in the features when opening the window. I think I was probably intending to do that (especially given the way I wrote the CSS) but missed it.

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9160350 [details] [diff] [review]
bug1649423_oauth_urlbar_missing.patch

Actually, no, this is right.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a37d8583cbd0
OAuth window missing URL bar after bug 1644083. r=darktrojan

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9160350 [details] [diff] [review]
bug1649423_oauth_urlbar_missing.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1644083
User impact if declined: URL bar of OAuth window not shown
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): Google requires the URL bar to be visible for OAuth. Worst case, the app privileges would get cancelled (and connecting to gmail thus no longer possible). The code change is small and well understood.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9160350 [details] [diff] [review]
bug1649423_oauth_urlbar_missing.patch

Approved for beta 79
Approved for esr 78.0  (Double checked in chat per below whether we should fast track this for esr)

darktrojan : I have approved esr uplifts. the only thing for beta is bug 1649423. how solid is that? And is it also important enough to risk for 78.0?  ... since it hasn't yet been on beta
wsmwk:  it's worth having and the risk is minimal since it's just CSS

Comment 7

[Geoff Lankow (:darktrojan)]

Thunderbird 79.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/efa858648f52

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.0.0 (build2):
https://hg.mozilla.org/releases/comm-esr78/rev/0e5778b2104a