Closed
Bug 1649596
Opened 4 years ago
Closed 4 years ago
CrashService.jsm imports OS.File during startup
Categories
(Toolkit Graveyard :: OS.File, task)
Toolkit Graveyard
OS.File
Tracking
(firefox82 fixed)
RESOLVED
FIXED
82 Branch
Tracking | Status | |
---|---|---|
firefox82 | --- | fixed |
People
(Reporter: beth, Assigned: beth)
References
Details
Attachments
(1 file)
According to this startup profile, CrashService.jsm runs during startup and imports osfile.jsm. We should migrate this to the new IOUtils replacement for osfile.jsm when possible.
Stack:
XREMain::XRE_main []
XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [libxul.so]
XREMain::XRE_mainRun() [libxul.so]
nsXREDirProvider::DoStartup() [libxul.so]
NS_CreateServicesFromCategory(char const*, nsISupports*, char const*, char16_t const*) [libxul.so]
nsCOMPtr_base::assign_from_gs_contractid(nsGetServiceByContractID, nsID const&) [libxul.so]
nsGetServiceByContractID::operator()(nsID const&, void**) const [libxul.so]
mozilla::xpcom::CreateInstanceImpl(mozilla::xpcom::ModuleID, nsISupports*, nsID const&, void**) [libxul.so]
mozilla::xpcom::ConstructJSMComponent(nsTSubstring<char> const&, char const*, nsISupports**) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
component loader load module []
mozJSComponentLoader::ObjectForLocation(ComponentLoaderInfo&, nsIFile*, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSScript*>, char**, bool, JS::MutableHandle<JS::Value>) [libxul.so]
js::ExecuteInJSMEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>) [libxul.so]
js::ExecuteInJSMEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, JS::Handle<JS::StackGCVector<JSObject*, js::TempAllocPolicy> >) [libxul.so]
ExecuteInExtensibleLexicalEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>) [libxul.so]
js::RunScript []
> resource://gre/modules/CrashService.jsm []
js::ExecuteKernel(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, JS::Handle<JS::Value>, js::AbstractFramePtr, JS::MutableHandle<JS::Value>) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
ChromeUtils.import []
mozilla::dom::ChromeUtils_Binding::import(JSContext*, unsigned int, JS::Value*) [libxul.so]
> ChromeUtils::Import resource://gre/modules/osfile.jsm []
mozilla::dom::ChromeUtils::Import(mozilla::dom::GlobalObject const&, nsTSubstring<char16_t> const&, mozilla::dom::Optional<JS::Handle<JSObject*> > const&, JS::MutableHandle<JSObject*>, mozilla::ErrorResult&) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
profiler_get_backtrace() [libxul.so]
Registers::SyncPopulate() [libxul.so]
Comment 1•4 years ago
|
||
Depends on D87488
Updated•4 years ago
|
Assignee: nobody → krourke
Status: NEW → ASSIGNED
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5de389b735d3
Use IOUtils instead of OS.File in CrashService.jsm r=barret,froydnj
Comment 3•4 years ago
|
||
Backed out for perma failures. See https://bugzilla.mozilla.org/show_bug.cgi?id=1660328#c5
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff93a88d2de2
Use IOUtils instead of OS.File in CrashService.jsm r=barret,froydnj
Comment 5•4 years ago
|
||
Backed out 3 changesets (Bug 1649595, Bug 1649596, Bug 1649593) for causing failures in ExtensionParent.jsm
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314443126&repo=autoland&lineNumber=3246
Backout: https://hg.mozilla.org/integration/autoland/rev/0b58d4793d6be1bcace9022cae96a9741db6e926
Flags: needinfo?(mail)
Assignee | ||
Comment 6•4 years ago
|
||
I'm taking these bugs over from :krourke since his internship is over.
Assignee: mail → brennie
Flags: needinfo?(mail)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1eed063f5bdc
Use IOUtils instead of OS.File in CrashService.jsm r=froydnj
Comment 8•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Updated•1 year ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•