1649804 - Drag and Drop of the contacts not working in the Address Book

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Khushil Mistry [:khushil324]]

JavaScript error: chrome://messenger/content/addressbook/abDragDrop.js, line 189: TypeError: can't access property "readOnly", srcDirectory is null

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1649804_DnD-Address-Book-not-working-0.patch

Comment 2

[Magnus Melin [:mkmelin]]

Please add more description of where it's broken.
Not sure what is expected to work, but there seems to be other cases causing js errors: e.g. dragging a contact from global address book to a list:
Uncaught
Exception { name: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS", message: "[JavaScript Error: "can't access property "dropCard", this._parent is undefined" {file: "resource:///modules/AddrBookMailingList.jsm" line: 165}]'[JavaScript Error: "can't access property "dropCard", this._parent is undefined" {file: "resource:///modules/AddrBookMailingList.jsm" line: 165}]' when calling method: [nsIAbDirectory::dropCard]", result: 2153185313, filename: "chrome://messenger/content/addressbook/abDragDrop.js", lineNumber: 315, columnNumber: 0, data: XPCWrappedNative_NoHelper, stack: "onDrop@chrome://messenger/content/addressbook/abDragDrop.js:315:19\ndrop@chrome://messenger/content/addressbook/abTrees.js:209:23\n", location: XPCWrappedNative_NoHelper }
abDragDrop.js:315

Comment 3

[Khushil Mistry [:khushil324]]

I have macOS Address Book as a read-only by default. When I try to DnD the contacts from the global address book to any address book apart from the macOS Address Book, it should work but it's not working and seeing the error: JavaScript error: chrome://messenger/content/addressbook/abDragDrop.js, line 189: TypeError: can't access property "readOnly", srcDirectory is null
DnD of the contacts from the one address book to another address book is working without this patch also(condition is both are read-write address books).
I am not seeing any errors you have mentioned.

Comment 4

[Geoff Lankow (:darktrojan)]

The original problem is dragging things out of the root address book, which makes srcDirectory null because that's how the root address book is represented now. The right thing to do is to find the real directory for the card(s) being dragged and use that. I've got a heap of patches dealing with things like this at the moment, and I know how I'd solve this in a tidy way, so I might as well just do it.

I haven't seen the comment 2 problem.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9160699 [details] [diff] [review]
Bug-1649804_DnD-Address-Book-not-working-0.patch

Review of attachment 9160699 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this won't be needed

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1649804 - Fix drag and drop problems in the address book

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a22c40ba81f1
Fix drag and drop problems in the address book r=pmorris

Comment 8

[Magnus Melin [:mkmelin]]

I guess we should uplift?

Comment 9

[Wayne Mery (:wsmwk)]

This also affects 68 ?

Comment 10

[Geoff Lankow (:darktrojan)]

That's a mistake.

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9161514 [details]
Bug 1649804 - Fix drag and drop problems in the address book

[Triage Comment]
Approved for esr78

Comment 12

[Geoff Lankow (:darktrojan)]

Not taking this to ESR for 78.1.1, it's too tangled up with bug 1650041.

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/0e89723b536d

Comment 14

[Rob Lemley [:rjl]]

Backout Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/c2e75246b71a

Approval flag set incorrectly.

Comment 15

[Rob Lemley [:rjl]]

Comment on attachment 9161514 [details]
Bug 1649804 - Fix drag and drop problems in the address book

[Approval Request Comment]
Resetting approval to ? since this bug is waiting for 78.2.

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9161514 [details]
Bug 1649804 - Fix drag and drop problems in the address book

[Triage Comment]
Approved for esr78

Comment 17

[Wayne Mery (:wsmwk)]

(In reply to Geoff Lankow (:darktrojan) from comment #12)

Not taking this to ESR for 78.1.1, it's too tangled up with bug 1650041.

n.b. this is also getting approval

Comment 18

[Geoff Lankow (:darktrojan)]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/295a1ff963aa