1650095 - Implement SessionHistoryEntry::Get/SetHasUserInteraction

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P2)

Comment 1

[Neha Kochar [:neha]]

Get/SetHasUserInteraction is no longer shipping so not a Fission blocker right now.

Comment 2

[Johann Hofmann [:johannh]]

Peter, I assume it's okay for me to take this?

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1650095 - Part 2 - Implement SessionHistoryEntry::Get/SetHasUserInteraction. r=peterv,smaug

Comment 4

[Johann Hofmann [:johannh]]

Attachment: Bug 1650095 - Part 1 - Collect current entry when partially updating session history. r=kashav,Gijs

This will ensure we reflect changes that were made to that entry after it was added, see
https://phabricator.services.mozilla.com/D93346#inline-535006 for more context.

Comment 5

[Johann Hofmann [:johannh]]

Attachment: Bug 1650095 - Part 3 - Make nsISHEntry.hasUserInteraction consistently forward to the root entry. r=smaug

This is more consistent than an assertion and it should be safe, considering that the field
should be unused on child entries anyway, so we might as well return the value from the root.

Depends on D93346

Comment 6

[Johann Hofmann [:johannh]]

Attachment: Bug 1650095 - Part 4 - For Fission, reset SHEntryHasUserInteraction cache in the parent when adding/updating SH entries. r=smaug

When re-enabling the test case blocked by bug 1670933 it became apparent that we were not allowing
session history entries to be marked with user interaction when the SH entry was created by navigation
through a sub-frame. The code that we had for this only covered updating SH entries after pushState etc.,
not adding new entries for document loads.

When SH lives in the child this is easier to manage in nsDocShell, but with Fission it probably makes sense
to move this code to the parent.

Depends on D95300

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb32728a96fc
Part 1 - Collect current entry when partially updating session history. r=kashav,Gijs
https://hg.mozilla.org/integration/autoland/rev/adf238e6c606
Part 2 - Implement SessionHistoryEntry::Get/SetHasUserInteraction. r=smaug
https://hg.mozilla.org/integration/autoland/rev/2acf8a782450
Part 3 - Make nsISHEntry.hasUserInteraction consistently forward to the root entry. r=smaug
https://hg.mozilla.org/integration/autoland/rev/53c001f92253
Part 4 - For Fission, reset SHEntryHasUserInteraction cache in the parent when adding/updating SH entries. r=smaug

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bb32728a96fc95fa4d0822fed30c6eb198f96298
https://hg.mozilla.org/mozilla-central/rev/adf238e6c6069008269fddfb18e1761b02f37e03
https://hg.mozilla.org/mozilla-central/rev/2acf8a782450d36dc9e8c334d93f583f5a91f79a
https://hg.mozilla.org/mozilla-central/rev/53c001f9225366cdabbbc38c1d560cdb482bd0db